From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@redhat.com, daniel@ffwll.ch, sam@ravnborg.org,
emil.l.velikov@gmail.com, kraxel@redhat.com,
yc_chen@aspeedtech.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: [PATCH v2 5/9] drm/ast: Don't use ast->dev if dev is available
Date: Thu, 30 Jul 2020 15:52:02 +0200 [thread overview]
Message-ID: <20200730135206.30239-6-tzimmermann@suse.de> (raw)
In-Reply-To: <20200730135206.30239-1-tzimmermann@suse.de>
Several places in ast use ast->dev, when a dev pointer is already
available within the function. Remove the extra indirection. No
functional changes made.
This is just a small cleanup before embedding the DRM device instance
in struct ast_private.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
---
drivers/gpu/drm/ast/ast_mode.c | 2 +-
drivers/gpu/drm/ast/ast_post.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index cdbdf3489dee..897a1ad2541e 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -1079,7 +1079,7 @@ int ast_mode_config_init(struct ast_private *ast)
dev->mode_config.min_height = 0;
dev->mode_config.preferred_depth = 24;
dev->mode_config.prefer_shadow = 1;
- dev->mode_config.fb_base = pci_resource_start(ast->dev->pdev, 0);
+ dev->mode_config.fb_base = pci_resource_start(dev->pdev, 0);
if (ast->chip == AST2100 ||
ast->chip == AST2200 ||
diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c
index c043fe717553..b1d42a639ece 100644
--- a/drivers/gpu/drm/ast/ast_post.c
+++ b/drivers/gpu/drm/ast/ast_post.c
@@ -368,9 +368,9 @@ void ast_post_gpu(struct drm_device *dev)
u32 reg;
struct ast_private *ast = to_ast_private(dev);
- pci_read_config_dword(ast->dev->pdev, 0x04, ®);
+ pci_read_config_dword(dev->pdev, 0x04, ®);
reg |= 0x3;
- pci_write_config_dword(ast->dev->pdev, 0x04, reg);
+ pci_write_config_dword(dev->pdev, 0x04, reg);
ast_enable_vga(dev);
ast_open_key(ast);
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-30 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 13:51 [PATCH v2 0/9] drm/ast: Convert to managed initialization Thomas Zimmermann
2020-07-30 13:51 ` [PATCH v2 1/9] drm/ast: Embed CRTC and connector in struct ast_private Thomas Zimmermann
2020-07-30 13:51 ` [PATCH v2 2/9] drm/ast: Separate DRM driver from PCI code Thomas Zimmermann
2020-07-30 13:52 ` [PATCH v2 3/9] drm/ast: Replace driver load/unload functions with device create/destroy Thomas Zimmermann
2020-07-30 13:52 ` [PATCH v2 4/9] drm/ast: Replace struct_drm_device.dev_private with to_ast_private() Thomas Zimmermann
2020-07-30 13:52 ` Thomas Zimmermann [this message]
2020-07-30 13:52 ` [PATCH v2 6/9] drm/ast: Embed struct drm_device in struct ast_private Thomas Zimmermann
2020-07-30 13:52 ` [PATCH v2 7/9] drm/ast: Managed release of ast firmware Thomas Zimmermann
2020-07-30 13:52 ` [PATCH v2 8/9] drm/ast: Manage release of firmware backup memory Thomas Zimmermann
2020-07-30 13:52 ` [PATCH v2 9/9] drm/ast: Managed device release Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730135206.30239-6-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=kraxel@redhat.com \
--cc=sam@ravnborg.org \
--cc=yc_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox