Re: [PATCH 3/4] drm/ttm: drop size from resource manager base class.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3416 bytes --]

Hi Dave,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next drm-exynos/exynos-drm-next v5.8 next-20200806]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dave-Airlie/drm-amdgpu-ttm-move-vram-gtt-mgr-allocations-to-mman/20200807-083526
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-a004-20200805 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project aa57cabae2fc5abc08ab3e17b45f2890fc7c9e42)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:474:5: warning: format specifies type 'unsigned long long' but the argument has type 'unsigned long' [-Wformat]
                     mgr_size << PAGE_SHIFT);
                     ^~~~~~~~~~~~~~~~~~~~~~
   include/drm/drm_print.h:490:32: note: expanded from macro 'DRM_DEBUG'
           __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__)
                                  ~~~    ^~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:493:2: warning: Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance 	 thanks to write-combining [-W#warnings]
   #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
    ^
   2 warnings generated.

vim +474 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

   440	
   441	/* Validate bo size is bit bigger then the request domain */
   442	static bool amdgpu_bo_validate_size(struct amdgpu_device *adev,
   443						  unsigned long size, u32 domain)
   444	{
   445		unsigned long mgr_size = 0;
   446		/*
   447		 * If GTT is part of requested domains the check must succeed to
   448		 * allow fall back to GTT
   449		 */
   450		if (domain & AMDGPU_GEM_DOMAIN_GTT) {
   451			mgr_size = to_gtt_mgr(ttm_manager_type(&adev->mman.bdev, TTM_PL_TT))->size;
   452	
   453			if (size < (mgr_size << PAGE_SHIFT))
   454				return true;
   455			else
   456				goto fail;
   457		}
   458	
   459		if (domain & AMDGPU_GEM_DOMAIN_VRAM) {
   460			mgr_size = to_vram_mgr(ttm_manager_type(&adev->mman.bdev, TTM_PL_TT))->size;
   461	
   462			if (size < (mgr_size << PAGE_SHIFT))
   463				return true;
   464			else
   465				goto fail;
   466		}
   467	
   468	
   469		/* TODO add more domains checks, such as AMDGPU_GEM_DOMAIN_CPU */
   470		return true;
   471	
   472	fail:
   473		DRM_DEBUG("BO size %lu > total memory in domain: %llu\n", size,
 > 474			  mgr_size << PAGE_SHIFT);
   475		return false;
   476	}
   477	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 43823 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel