From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D77DC433E3 for ; Sat, 8 Aug 2020 21:02:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E585B2075D for ; Sat, 8 Aug 2020 21:02:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Tr3ZDKIU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E585B2075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 257826E262; Sat, 8 Aug 2020 21:02:40 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E6B06E262 for ; Sat, 8 Aug 2020 21:02:38 +0000 (UTC) Received: from pendragon.ideasonboard.com (85-76-78-184-nat.elisa-mobile.fi [85.76.78.184]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4AC2DF9; Sat, 8 Aug 2020 23:02:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1596920554; bh=vINdyI0QCckZCf5KNzdqgtA/iyl+UJhlXN/pjqWdvHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tr3ZDKIU7VvZv5QU7zUuZjEn4MT79dGZ8kmsjcPXEjufzfADIp/qBt5zi8gVowQYC 10vtti+jZTAGdHO+JOxzmeVwm8nmTl12X4Fcil9xwZishp7xL+Say8oh9ptEWbCaaK 28ZsjKtD9xb7433fwZSj1RvE2rrX6jG62DR2zulI= Date: Sun, 9 Aug 2020 00:02:19 +0300 From: Laurent Pinchart To: Lad Prabhakar Subject: Re: [PATCH 2/7] drm: rcar-du: Add r8a7742 support Message-ID: <20200808210219.GN6186@pendragon.ideasonboard.com> References: <20200807174954.14448-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200807174954.14448-3-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807174954.14448-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Geert Uytterhoeven , David Airlie , Kieran Bingham , Magnus Damm , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Rob Herring Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote: > Add direct support for the r8a7742 (RZ/G1H). > > The RZ/G1H shares a common, compatible configuration with the r8a7790 > (R-Car H2) so that device info structure is reused, the only difference > being TCON is unsupported on RZ/G1H (Currently unsupported by the driver). > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 3e67cf70f040..7e286c7a7a6c 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = { > .channels_mask = BIT(2) | BIT(1) | BIT(0), > .routes = { > /* > - * R8A7790 has one RGB output, two LVDS outputs and one > - * (currently unsupported) TCON output. > + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally > + * R8A7790 supports one TCON output (currently unsupported by the driver). Once we support TCON we'll have to split this, but for now I suppose it's fine. Would you however mind wrapping this to 80 columns ? I can do so when applying if it's fine with you. Reviewed-by: Laurent Pinchart > */ > [RCAR_DU_OUTPUT_DPAD0] = { > .possible_crtcs = BIT(2) | BIT(1) | BIT(0), > @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > }; > > static const struct of_device_id rcar_du_of_table[] = { > + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info }, > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel