From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDDBEC433E0 for ; Tue, 11 Aug 2020 11:00:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B008020656 for ; Tue, 11 Aug 2020 11:00:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VXk0zYVQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B008020656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F7226E4F8; Tue, 11 Aug 2020 11:00:13 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C0DC6E4FE for ; Tue, 11 Aug 2020 11:00:11 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B26E99A8; Tue, 11 Aug 2020 13:00:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1597143608; bh=XY+WuRlsiCQJwziOQYlWOYnlEUvnKKZa8SJ/PfngfZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VXk0zYVQ6fFufVsmZOBnMftFizjahyf5J9cy+lR7onuBkv1wnPgksE82vMexY2Bqz 1a9zlKinwbxXE2OGyYSwxXMMrqk88Eekf1/UBYmuh7yGJyoLqnR2IrfF7J1U8PtVGg zj++V08KIGDKsOcyRl+xCZOduhKDy/SzDIul2/Qo= Date: Tue, 11 Aug 2020 13:59:55 +0300 From: Laurent Pinchart To: Biju Das Subject: Re: [PATCH v2 2/3] drm/bridge: lvds-codec: Add support for regulator Message-ID: <20200811105955.GE6054@pendragon.ideasonboard.com> References: <20200810152219.6254-1-biju.das.jz@bp.renesas.com> <20200810152219.6254-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200810152219.6254-3-biju.das.jz@bp.renesas.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Geert Uytterhoeven , Jonas Karlman , David Airlie , Prabhakar Mahadev Lad , Neil Armstrong , Chris Paterson , dri-devel@lists.freedesktop.org, Biju Das , linux-renesas-soc@vger.kernel.org, Andrzej Hajda , Fabrizio Castro Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Biju, Thank you for the patch. On Mon, Aug 10, 2020 at 04:22:18PM +0100, Biju Das wrote: > Add the support for enabling optional regulator that may be used as VCC > source. > > Signed-off-by: Biju Das > --- > New Patch Ref: Ref:https://patchwork.kernel.org/patch/11705819/ > --- > drivers/gpu/drm/bridge/lvds-codec.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c > index 24fb1befdfa2..5858a29aafe6 100644 > --- a/drivers/gpu/drm/bridge/lvds-codec.c > +++ b/drivers/gpu/drm/bridge/lvds-codec.c > @@ -10,13 +10,16 @@ > #include > #include > #include > +#include > > #include > #include > > struct lvds_codec { > + struct device *dev; > struct drm_bridge bridge; > struct drm_bridge *panel_bridge; > + struct regulator *vcc; > struct gpio_desc *powerdown_gpio; > u32 connector_type; > }; > @@ -38,6 +41,14 @@ static int lvds_codec_attach(struct drm_bridge *bridge, > static void lvds_codec_enable(struct drm_bridge *bridge) > { > struct lvds_codec *lvds_codec = to_lvds_codec(bridge); > + int ret; > + > + ret = regulator_enable(lvds_codec->vcc); > + if (ret) { > + dev_err(lvds_codec->dev, > + "Failed to enable regulator \"vcc\": %d\n", ret); > + return; > + } > > if (lvds_codec->powerdown_gpio) > gpiod_set_value_cansleep(lvds_codec->powerdown_gpio, 0); > @@ -46,9 +57,15 @@ static void lvds_codec_enable(struct drm_bridge *bridge) > static void lvds_codec_disable(struct drm_bridge *bridge) > { > struct lvds_codec *lvds_codec = to_lvds_codec(bridge); > + int ret; > > if (lvds_codec->powerdown_gpio) > gpiod_set_value_cansleep(lvds_codec->powerdown_gpio, 1); > + > + ret = regulator_disable(lvds_codec->vcc); > + if (ret) > + dev_err(lvds_codec->dev, > + "Failed to disable regulator \"vcc\": %d\n", ret); > } > > static const struct drm_bridge_funcs funcs = { > @@ -63,12 +80,24 @@ static int lvds_codec_probe(struct platform_device *pdev) > struct device_node *panel_node; > struct drm_panel *panel; > struct lvds_codec *lvds_codec; > + int error; The driver tends to use "ret" for error status variables. If you're fine with this change there's no need to resubmit the patch, I can fix when applying. Reviewed-by: Laurent Pinchart > > lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL); > if (!lvds_codec) > return -ENOMEM; > > + lvds_codec->dev = &pdev->dev; > lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev); > + > + lvds_codec->vcc = devm_regulator_get(lvds_codec->dev, "vcc"); > + if (IS_ERR(lvds_codec->vcc)) { > + error = PTR_ERR(lvds_codec->vcc); > + if (error != -EPROBE_DEFER) > + dev_err(lvds_codec->dev, > + "Unable to get \"vcc\" supply: %d\n", error); > + return error; > + } > + > lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", > GPIOD_OUT_HIGH); > if (IS_ERR(lvds_codec->powerdown_gpio)) { -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel