From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74516C433DF for ; Sat, 15 Aug 2020 08:39:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A60722EBF for ; Sat, 15 Aug 2020 08:39:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A60722EBF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28FE16E088; Sat, 15 Aug 2020 08:39:29 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 554E86E088 for ; Sat, 15 Aug 2020 08:39:27 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id DC50880533; Sat, 15 Aug 2020 10:39:18 +0200 (CEST) Date: Sat, 15 Aug 2020 10:39:17 +0200 From: Sam Ravnborg To: Guido =?iso-8859-1?Q?G=FCnther?= Subject: Re: [PATCH 2/3] dt-bindings: Add Mantix MLAF057WE51-X panel bindings Message-ID: <20200815083917.GA993113@ravnborg.org> References: <9345739df02b8b8630e7dccb61a80a7a7f692526.1597412076.git.agx@sigxcpu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9345739df02b8b8630e7dccb61a80a7a7f692526.1597412076.git.agx@sigxcpu.org> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=ze386MxoAAAA:8 a=gEfo2CItAAAA:8 a=VwQbUJbxAAAA:8 a=6yzhs6WGAAAA:8 a=e5mUnYsNAAAA:8 a=hVRzqGFF_kdORxQG3GsA:9 a=wPNLvfGTeEIA:10 a=iBZjaW-pnkserzjvUTHh:22 a=sptkURWiP4Gy88Gu7hUp:22 a=AjGcO6oz07-iQ99wixmX:22 a=j5F3_G_i7ziBYwdlbqZG:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mauro Carvalho Chehab , Kuninori Morimoto , Arnd Bergmann , David Airlie , Heiko Stuebner , Daniel Palmer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Lubomir Rintel , Rob Herring , Thierry Reding , Mark Brown , allen , "David S. Miller" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Guido. On Fri, Aug 14, 2020 at 03:36:22PM +0200, Guido G=FCnther wrote: > The panel uses a Focaltech FT8006p, the touch part is handled by the > already existing edt-ft5x06. > = > Signed-off-by: Guido G=FCnther A few trivialities. > --- > .../display/panel/mantix,mlaf057we51-x.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/manti= x,mlaf057we51-x.yaml > = > diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf0= 57we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf= 057we51-x.yaml > new file mode 100644 > index 0000000000000..349f3380ac940 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-= x.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/mantix,mlaf057we51-x.ya= ml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mantix MLAF057WE51-X 5.7" 720x1440 TFT LCD panel > + > +maintainers: > + - Guido G=FCnther > + > +description: | > + Mantix MLAF057WE51 X is a 720x1440 TFT LCD panel > + connected using a MIPI-DSI video interface. Indent text with two spaces only. And I have learned that '|' is only needed to preserve formatting - so it can be dropped. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + enum: > + - mantix,mlaf057we51-x This is a list - so needs an extra 2 spaces indent. See https://lore.kernel.org/linux-devicetree/f1963eb9-283f-e903-2a3a-4f324d= 71d418@lucaceresoli.net/T/#m65900317fb948f6c40e8fb521f2201fba3c301a7 for examples where Rob fixes this. > + > + port: true > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + avdd-supply: > + description: Positive analog power supply > + > + avee-supply: > + description: Negative analog power supply > + > + vddi-supply: > + description: 1.8V I/O voltage supply > + > + reset-gpios: > + description: GPIO used for the reset pin > + maxItems: 1 Use reset-gpios: true as we already have it in panel-common.yaml > + > + backlight: > + description: Backlight used by the panel > + $ref: "/schemas/types.yaml#/definitions/phandle" Use backlight from panel-common.yaml. > + > +required: > + - compatible > + - reg > + - avdd-supply > + - avee-supply > + - vddi-supply > + - reset-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + dsi { My personal preference is indent with 4 spaces in examples but there are no rules so feel free to ignore. > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + panel@0 { > + compatible =3D "mantix,mlaf057we51-x"; > + reg =3D <0>; > + avdd-supply =3D <®_avdd>; > + avee-supply =3D <®_avee>; > + vddi-supply =3D <®_1v8_p>; > + reset-gpios =3D <&gpio1 29 GPIO_ACTIVE_LOW>; > + backlight =3D <&backlight>; > + }; > + }; I think we need an ampty line here. > +... > -- = > 2.26.2 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel