Re: [PATCH 4/4] drm/crtc: add drmm_crtc_alloc_with_planes()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3477 bytes --]

Hi Philipp,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip linus/master v5.9-rc2 next-20200826]
[cannot apply to tegra-drm/drm/tegra/for-next drm-exynos/exynos-drm-next drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Philipp-Zabel/drm-add-drmm_encoder_alloc/20200826-203629
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a003-20200826 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 7cfcecece0e0430937cf529ce74d3a071a4dedc6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_crtc.c:336:1: warning: all paths through this function will call itself [-Winfinite-recursion]
   {
   ^
   1 warning generated.

# https://github.com/0day-ci/linux/commit/236b7bc44ae0fdecc8e80c5aba0655ca14fdfb23
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Philipp-Zabel/drm-add-drmm_encoder_alloc/20200826-203629
git checkout 236b7bc44ae0fdecc8e80c5aba0655ca14fdfb23
vim +336 drivers/gpu/drm/drm_crtc.c

   311	
   312	/**
   313	 * drm_crtc_init_with_planes - Initialise a new CRTC object with
   314	 *    specified primary and cursor planes.
   315	 * @dev: DRM device
   316	 * @crtc: CRTC object to init
   317	 * @primary: Primary plane for CRTC
   318	 * @cursor: Cursor plane for CRTC
   319	 * @funcs: callbacks for the new CRTC
   320	 * @name: printf style format string for the CRTC name, or NULL for default name
   321	 *
   322	 * Inits a new object created as base part of a driver crtc object. Drivers
   323	 * should use this function instead of drm_crtc_init(), which is only provided
   324	 * for backwards compatibility with drivers which do not yet support universal
   325	 * planes). For really simple hardware which has only 1 plane look at
   326	 * drm_simple_display_pipe_init() instead.
   327	 *
   328	 * Returns:
   329	 * Zero on success, error code on failure.
   330	 */
   331	int drm_crtc_init_with_planes(struct drm_device *dev, struct drm_crtc *crtc,
   332				      struct drm_plane *primary,
   333				      struct drm_plane *cursor,
   334				      const struct drm_crtc_funcs *funcs,
   335				      const char *name, ...)
 > 336	{
   337		va_list ap;
   338		int ret;
   339	
   340		if (name)
   341			va_start(ap, name);
   342		ret = drm_crtc_init_with_planes(dev, crtc, primary, cursor, funcs,
   343						name, ap);
   344		if (name)
   345			va_end(ap);
   346	
   347		return ret;
   348	}
   349	EXPORT_SYMBOL(drm_crtc_init_with_planes);
   350	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47458 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel