From: Luben Tuikov <luben.tuikov@amd.com>
To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Alexander Deucher <Alexander.Deucher@amd.com>,
Luben Tuikov <luben.tuikov@amd.com>,
Xinhui.Pan@amd.com
Subject: [PATCH 2/3] drm/amdgpu: Remove drmm final free
Date: Tue, 1 Sep 2020 21:06:44 -0400 [thread overview]
Message-ID: <20200902010645.26943-3-luben.tuikov@amd.com> (raw)
In-Reply-To: <20200902010645.26943-1-luben.tuikov@amd.com>
The amdgpu driver implements its own DRM driver
release function which naturally frees
the container struct amdgpu_device of
the DRM device, on a "final" kref-put,
i.e. when the kref transitions from non-zero
to 0.
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 459cf13e76fe..17d49f1d86e7 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1153,8 +1153,6 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
if (ret)
goto err_free;
- drmm_add_final_kfree(ddev, ddev);
-
if (!supports_atomic)
ddev->driver_features &= ~DRIVER_ATOMIC;
--
2.28.0.394.ge197136389
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-02 1:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 1:06 [PATCH 0/3] Use implicit kref infra Luben Tuikov
2020-09-02 1:06 ` [PATCH 1/3] drm: No warn for drivers who provide release Luben Tuikov
2020-09-02 1:06 ` Luben Tuikov [this message]
2020-09-02 1:06 ` [PATCH 3/3] drm/amdgpu: Remove superfluous NULL check Luben Tuikov
2020-09-02 6:59 ` Daniel Vetter
2020-09-02 7:21 ` Christian König
2020-09-02 1:42 ` [PATCH 0/3] Use implicit kref infra Pan, Xinhui
2020-09-02 3:46 ` Luben Tuikov
2020-09-02 4:43 ` Pan, Xinhui
2020-09-02 14:50 ` Luben Tuikov
2020-09-02 15:00 ` Daniel Stone
2020-09-02 15:16 ` Luben Tuikov
2020-09-02 15:51 ` Daniel Stone
2020-09-02 19:04 ` Luben Tuikov
2020-09-02 19:16 ` Alex Deucher
2020-09-02 19:55 ` Daniel Vetter
2020-09-02 19:59 ` Daniel Vetter
2020-09-03 1:57 ` Pan, Xinhui
2020-09-03 18:52 ` Luben Tuikov
2020-09-02 6:52 ` Daniel Vetter
2020-09-02 14:59 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902010645.26943-3-luben.tuikov@amd.com \
--to=luben.tuikov@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox