From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 949CEC433E7 for ; Wed, 2 Sep 2020 06:59:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 693BB20826 for ; Wed, 2 Sep 2020 06:59:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="hFGXoZ4F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 693BB20826 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 407276E127; Wed, 2 Sep 2020 06:59:10 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 692576E127 for ; Wed, 2 Sep 2020 06:59:09 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id z1so4004582wrt.3 for ; Tue, 01 Sep 2020 23:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0pqHRfpr6UrjNvbY/R9ZrWji8L8XsS+WJrZoowuq3CI=; b=hFGXoZ4FFNRD4jI5y5iYxtLPTKZCFlAIprIwSufOwhBSVaFP+52L3gVQxCsv45z5ge HUqCe6pvEJh+QdY8c9UjMrcNaoE/juyVOBo1Wbh3ZRaWY3hDXt75EL6LLcAD1npy/KYq gMMqC6JsvUTwCOvZSow76odIeTe/j5H0zZkAg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0pqHRfpr6UrjNvbY/R9ZrWji8L8XsS+WJrZoowuq3CI=; b=IgjnkTZxncndSltnCXH7oajdjADvE8DGvpv88HZrMGa/DRA/RHIWKIkY+YepSxoKM1 M4sJOncXe0HoUjE6OI1cLQLwOu9alSMgTQgV/XLK8z4nbP9yTimcqoBpiGnfBslytHc4 KtViXVXkCQWVSd4jGW5qMmlW7EcPo0h942vGd1qFDGOCUEKZK3+NRNjRlBsjEgDOUvzG q5zFNXdIdtXPlgL/08GZ0k39RRwIktqAkqaup0t7H0cko1y5qa9rwmhEuc5c58a5GsIh tkuGcidss0rTx6bqKZI4+nHKXjGyv7U9BrmmBV7ytMTnzOL65VqdcfcP1RfxMKiNIo+v f2FQ== X-Gm-Message-State: AOAM532+FUfIs6efztGIMS3Vm64LO56qHB3q6lDIakLnlUCxnCC0ksSB dCpP7WFMxb0YXp5IRWJUMNDQ9g== X-Google-Smtp-Source: ABdhPJzagT929ndRY9I71kezYTJbV+uiZ4kTVb4zf4B55/0+JigztoYvjxClbZ1ZrimoU/X1X9ZpBA== X-Received: by 2002:adf:c182:: with SMTP id x2mr5612366wre.400.1599029948165; Tue, 01 Sep 2020 23:59:08 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id h6sm66345wmb.22.2020.09.01.23.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 23:59:07 -0700 (PDT) Date: Wed, 2 Sep 2020 08:59:05 +0200 From: Daniel Vetter To: Luben Tuikov Subject: Re: [PATCH 3/3] drm/amdgpu: Remove superfluous NULL check Message-ID: <20200902065905.GG2352366@phenom.ffwll.local> References: <20200902010645.26943-1-luben.tuikov@amd.com> <20200902010645.26943-4-luben.tuikov@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200902010645.26943-4-luben.tuikov@amd.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Deucher , Xinhui.Pan@amd.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 01, 2020 at 09:06:45PM -0400, Luben Tuikov wrote: > The DRM device is a static member of > the amdgpu device structure and as such > always exists, so long as the PCI and > thus the amdgpu device exist. > > Signed-off-by: Luben Tuikov On this patch, but not the other two earlier in this series: Acked-by: Daniel Vetter > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index c4900471beb0..6dcc256b9ebc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -3471,9 +3471,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool fbcon) > struct drm_connector_list_iter iter; > int r; > > - if (!dev) > - return -ENODEV; > - > adev = drm_to_adev(dev); > > if (dev->switch_power_state == DRM_SWITCH_POWER_OFF) > -- > 2.28.0.394.ge197136389 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel