From: Daniel Vetter <daniel@ffwll.ch>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Anitha Chrisanthus <anitha.chrisanthus@intel.com>,
daniel.vetter@intel.com, edmund.j.dea@intel.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display
Date: Fri, 11 Sep 2020 10:56:42 +0200 [thread overview]
Message-ID: <20200911085642.GR438822@phenom.ffwll.local> (raw)
In-Reply-To: <20200910183343.GC893045@ravnborg.org>
On Thu, Sep 10, 2020 at 08:33:43PM +0200, Sam Ravnborg wrote:
> Hi Daniel.
>
> > > + }
> > > +
> > > + /* Initialize MIPI DSI */
> > > + ret = kmb_dsi_init(drm, adv_bridge);
> >
> > Split up isn't correct here, this won't compile since the dsi code isn't
> > in this patch yet. So you need to have this ordered the other way round.
>
> I have explicit asked for a simple file split as done here
> and told Anitha this was fine.
>
> As the kbuild/kconfig bits are the last patch then no build breakage.
> The file based split was IMO fine to ease review.
>
> If this is not OK then blame me :-)
Ah I missed that, sounds ok for me too then :-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-11 8:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 20:02 [PATCH v7 0/4] Add support for KeemBay DRM driver Anitha Chrisanthus
2020-08-31 20:02 ` [PATCH v7 1/4] drm/kmb: Keem Bay driver register definition Anitha Chrisanthus
2020-08-31 20:02 ` [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display Anitha Chrisanthus
2020-09-10 8:30 ` Daniel Vetter
2020-09-10 18:33 ` Sam Ravnborg
2020-09-11 8:56 ` Daniel Vetter [this message]
2020-09-22 18:20 ` Chrisanthus, Anitha
2020-09-23 15:22 ` Daniel Vetter
2020-10-01 18:02 ` Chrisanthus, Anitha
2020-10-02 9:19 ` Daniel Vetter
2020-10-03 4:58 ` Chrisanthus, Anitha
2020-10-05 13:49 ` Daniel Vetter
2020-10-06 0:22 ` Chrisanthus, Anitha
2020-09-10 8:40 ` Daniel Vetter
2020-09-10 9:32 ` Neil Armstrong
2020-09-11 20:54 ` Chrisanthus, Anitha
2020-09-12 20:20 ` Sam Ravnborg
2020-08-31 20:02 ` [PATCH v7 3/4] drm/kmb: Mipi DSI part of the display driver Anitha Chrisanthus
2020-09-10 8:38 ` Daniel Vetter
2020-08-31 20:02 ` [PATCH v7 4/4] drm/kmb: Build files for KeemBay Display driver Anitha Chrisanthus
2020-09-10 8:42 ` [PATCH v7 0/4] Add support for KeemBay DRM driver Daniel Vetter
2020-09-10 22:45 ` Chrisanthus, Anitha
2020-10-07 13:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911085642.GR438822@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=anitha.chrisanthus@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox