From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F211C4363D for ; Wed, 23 Sep 2020 07:53:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 443B121924 for ; Wed, 23 Sep 2020 07:53:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=endlessos-org.20150623.gappssmtp.com header.i=@endlessos-org.20150623.gappssmtp.com header.b="KnK7Yrl5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 443B121924 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=endlessos.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD8746E0AA; Wed, 23 Sep 2020 07:53:20 +0000 (UTC) Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by gabe.freedesktop.org (Postfix) with ESMTPS id C93106E441 for ; Wed, 23 Sep 2020 07:00:43 +0000 (UTC) Received: by mail-pl1-x641.google.com with SMTP id u4so614312plr.4 for ; Wed, 23 Sep 2020 00:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessos-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4oRwmR3EhcJbAFucNH/94gqJmXyc3Ivz1Uey2cJmuPM=; b=KnK7Yrl5N78RVstfT4p+cHqser1Rh3nceDzmrZ9asUN8ZJdo0tbpjiCa0qEf5iMDlN g1lXCGvY88a8cVIypjS//QW+6FIeK2n1vWRhrhFPnragCHv5lxfx0y76pjYusiVViGPN vXq8jofjEMP2H8IcVmi+cjvG5M3HTmwqTOjiMml3dElEIY0uscYjv/xOf4CU81TNau3N LsLFtz7eU5n6uYTbOiak194H8+DJEjOFpffvb+JB6oXdqoV+5zDwkofhsyH71yEFeZ3h oPnf7Uf0qKUNdfpBXOWEU8M6FjK1Igh+Cqr4bgZaFoItzAd8avdZwmo7OJvDGiTtHujR dOZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4oRwmR3EhcJbAFucNH/94gqJmXyc3Ivz1Uey2cJmuPM=; b=ddlpFlS3P1bbIJ05w5pRmA9ske4fCJUtt1wVwhTujTey7SDU2B4Oq+5xPntEP5Fkbl NLxUpfmdF8ru+SgByYAH99beBIheNGVO0tSVlnZtGpJ45WmyxVmsd4m4cVJQmA8md6RT +vfC17OejOI9e9kDiO4esADGvStykCwBtt7hk9x94cn7M4Xi/Iyn77kTukgTwvUaHVv2 A7ttq4NjoxJId9kfIjjjshh3fMZ89689tTfFw1ZJmiRb+2e5ZcjjmoVugA5gchk2n8Yj UBh8bdeN48wrGnOI6hdx5hHvmg2knNlYTAT7i1Paw4+mmfm0LPuMCWyCvu85ReUCaopp R2fQ== X-Gm-Message-State: AOAM531Uw0RGKOffwOe9LbpPXyy5LfXjVQi18HfNA/O1PbzEljs8vTmX SoPGFncAYKIcU50f439cfNT+oA== X-Google-Smtp-Source: ABdhPJz3kVpgSu//J46x/GTqCeisWVwS2nfBoJ8yAFUJqHmANvefDc9kzIAfNXlfMpEbuZT0p9avNw== X-Received: by 2002:a17:902:8695:b029:d2:29b:991a with SMTP id g21-20020a1709028695b02900d2029b991amr8436516plo.80.1600844443090; Wed, 23 Sep 2020 00:00:43 -0700 (PDT) Received: from starnight.localdomain (123-204-46-122.static.seed.net.tw. [123.204.46.122]) by smtp.googlemail.com with ESMTPSA id j18sm16090095pgm.30.2020.09.23.00.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 00:00:42 -0700 (PDT) From: Jian-Hong Pan To: =?UTF-8?q?Heiko=20St=C3=BCbner?= , David Airlie , Daniel Vetter Subject: [PATCH] drm/rockchip: skip probed failed device Date: Wed, 23 Sep 2020 14:59:00 +0800 Message-Id: <20200923065900.658666-1-jhp@endlessos.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: References: MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 23 Sep 2020 07:53:19 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jian-Hong Pan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux@endlessm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The cdn-dp sub driver probes the device failed on PINEBOOK Pro. kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy kernel: cdn-dp: probe of fec00000.dp failed with error -22 Then, the device halts all of the DRM related device jobs. For example, the operations: vop_component_ops, vop_component_ops and rockchip_dp_component_ops cannot be bound to corresponding devices. So, Xorg cannot find the correct DRM device. This patch skips the probing failed devices to fix this issue. Link: http://lists.infradead.org/pipermail/linux-rockchip/2020-September/022352.html Signed-off-by: Jian-Hong Pan --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 0f3eb392fe39..de13588602b4 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c @@ -331,6 +331,12 @@ static struct component_match *rockchip_drm_match_add(struct device *dev) if (!d) break; + if (!d->driver) { + DRM_DEV_ERROR(d, + "%s did not probe successfully", + drv->driver.name); + continue; + } device_link_add(dev, d, DL_FLAG_STATELESS); component_match_add(dev, &match, compare_dev, d); -- 2.28.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel