From: Daniel Vetter <daniel@ffwll.ch>
To: Melissa Wen <melissa.srw@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/3] drm/vkms: fbdev emulation support
Date: Tue, 20 Oct 2020 10:34:30 +0200 [thread overview]
Message-ID: <20201020083430.GK401619@phenom.ffwll.local> (raw)
In-Reply-To: <20201016101056.gqp4ezu7pyeqa6el@smtp.gmail.com>
On Fri, Oct 16, 2020 at 07:10:56AM -0300, Melissa Wen wrote:
> Hi,
>
> Thanks for this improvement.
>
> I could see that it increased the IGT test coverage, including now the
> fbdev test cases.
>
> On 10/10, Daniel Vetter wrote:
> > Hooray for generic fbdev support, making this a oneliner. We just
> > needed to fix preferred_depth fixed and the vmap support added first.
>
> I consider that including in the msg that, with this patch, both fbdev
> test cases [info and mmap] are passing would be interesting for future
> debugs.
Done and patch applied, thanks for taking a look. I'll also follow up with
a quick patch to paper over the fbdev vs preferred_depth issue, until we
have a proper solution for all that.
-Daniel
>
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> > Cc: Melissa Wen <melissa.srw@gmail.com>
> > Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > ---
> > drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> > index 6221e5040264..cc09e2df5cb1 100644
> > --- a/drivers/gpu/drm/vkms/vkms_drv.c
> > +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> > @@ -169,6 +169,8 @@ static int __init vkms_init(void)
> > if (ret)
> > goto out_devres;
> >
> > + drm_fbdev_generic_setup(&vkms_device->drm, 0);
> > +
> > return 0;
> >
> > out_devres:
> > --
> > 2.28.0
> >
>
> Looks good to me,
>
> Reviewed-by: Melissa Wen <melissa.srw@gmail.com>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-20 8:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 23:21 [PATCH 1/3] drm/vkms: Set preferred depth correctly Daniel Vetter
2020-10-09 23:21 ` [PATCH 2/3] drm/vkms: Switch to shmem helpers Daniel Vetter
2020-10-12 10:59 ` Chris Wilson
2020-10-12 11:20 ` Thomas Zimmermann
2020-10-12 11:22 ` Thomas Zimmermann
2020-10-12 12:41 ` Melissa Wen
2020-10-13 11:10 ` [PATCH] " Daniel Vetter
2020-10-09 23:21 ` [PATCH 3/3] drm/vkms: fbdev emulation support Daniel Vetter
2020-10-12 11:24 ` Thomas Zimmermann
2020-10-12 12:40 ` Neil Armstrong
2020-10-12 14:23 ` Daniel Vetter
2020-10-13 6:14 ` Pekka Paalanen
2020-10-13 7:53 ` Daniel Vetter
2020-10-13 10:19 ` Pekka Paalanen
2020-10-13 11:03 ` Daniel Vetter
2020-10-16 10:10 ` Melissa Wen
2020-10-20 8:34 ` Daniel Vetter [this message]
2020-10-12 11:08 ` [PATCH 1/3] drm/vkms: Set preferred depth correctly Thomas Zimmermann
2020-10-12 12:59 ` Melissa Wen
2020-10-15 21:39 ` Daniel Vetter
2020-10-16 10:18 ` Melissa Wen
2020-10-16 10:38 ` Simon Ser
2020-10-16 11:35 ` Daniel Vetter
2020-10-16 17:02 ` Melissa Wen
2020-10-16 17:05 ` Daniel Vetter
2020-10-17 8:39 ` Melissa Wen
2020-10-17 15:23 ` Daniel Vetter
2020-10-27 10:13 ` Thomas Zimmermann
2020-10-27 10:18 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020083430.GK401619@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=melissa.srw@gmail.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox