From: "Guido Günther" <agx@sigxcpu.org>
To: Daniel Abrecht <freedesktop-linux-dri-devel@danielabrecht.ch>
Cc: Marek Vasut <marex@denx.de>,
kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
linux-imx@nxp.com
Subject: Re: [PATCH] Implement .format_mod_supported in mxsfb
Date: Sun, 25 Oct 2020 16:52:01 +0100 [thread overview]
Message-ID: <20201025155201.GA25070@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <96f62304bad202e4f920d2f4ed62c485@abrecht.li>
Hi Daniel,
On Sat, Oct 24, 2020 at 04:59:16PM +0000, Daniel Abrecht wrote:
> This will make sure applications which use the IN_FORMATS blob
> to figure out which modifiers they can use will pick up the
> linear modifier which is needed by mxsfb. Such applications
> will not work otherwise if an incompatible implicit modifier
> ends up being selected.
Since this got broken by the switch away for the simple display
pipeline helper (ae1ed0093281939b80664a687689f12436c0e874) could
you add a fixes tag?
Cheers,
-- Guido
>
> Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
> b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
> index 956f631997f2..fc4b1626261b 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
> @@ -484,6 +484,13 @@ static void mxsfb_plane_overlay_atomic_update(struct
> drm_plane *plane,
> writel(ctrl, mxsfb->base + LCDC_AS_CTRL);
> }
>
> +static bool mxsfb_format_mod_supported(struct drm_plane *plane,
> + uint32_t format,
> + uint64_t modifier)
> +{
> + return modifier == DRM_FORMAT_MOD_LINEAR;
> +}
> +
> static const struct drm_plane_helper_funcs mxsfb_plane_primary_helper_funcs
> = {
> .atomic_check = mxsfb_plane_atomic_check,
> .atomic_update = mxsfb_plane_primary_atomic_update,
> @@ -495,6 +502,7 @@ static const struct drm_plane_helper_funcs
> mxsfb_plane_overlay_helper_funcs = {
> };
>
> static const struct drm_plane_funcs mxsfb_plane_funcs = {
> + .format_mod_supported = mxsfb_format_mod_supported,
> .update_plane = drm_atomic_helper_update_plane,
> .disable_plane = drm_atomic_helper_disable_plane,
> .destroy = drm_plane_cleanup,
> --
> 2.20.1
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-25 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 16:59 [PATCH] Implement .format_mod_supported in mxsfb Daniel Abrecht
2020-10-25 15:52 ` Guido Günther [this message]
2020-10-25 19:50 ` Daniel Abrecht
2020-10-26 9:05 ` Daniel Vetter
2020-10-26 10:52 ` Ville Syrjälä
2020-10-26 11:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201025155201.GA25070@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedesktop-linux-dri-devel@danielabrecht.ch \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox