From: Rob Herring <robh@kernel.org>
To: Akhil P Oommen <akhilpo@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
mka@chromium.org, dri-devel@freedesktop.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] dt-bindings: drm/msm/gpu: Add cooling device support
Date: Mon, 26 Oct 2020 08:37:50 -0500 [thread overview]
Message-ID: <20201026133750.GA41262@bogus> (raw)
In-Reply-To: <1603113268-21161-3-git-send-email-akhilpo@codeaurora.org>
On Mon, Oct 19, 2020 at 06:44:28PM +0530, Akhil P Oommen wrote:
> Add cooling device support to gpu. A cooling device is bound to a
> thermal zone to allow thermal mitigation.
>
> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
> ---
> Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt
> index 1af0ff1..a496381 100644
> --- a/Documentation/devicetree/bindings/display/msm/gpu.txt
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt
> @@ -39,6 +39,10 @@ Required properties:
> a4xx Snapdragon SoCs. See
> Documentation/devicetree/bindings/sram/qcom,ocmem.yaml.
>
> +Optional properties:
> +- #cooling-cells: The value must be 2. Please refer
> + Documentation/devicetree/bindings/thermal/thermal.txt for detail.
This file doesn't exist anymore.
> +
> Example 3xx/4xx:
>
> / {
> @@ -61,6 +65,7 @@ Example 3xx/4xx:
> power-domains = <&mmcc OXILICX_GDSC>;
> operating-points-v2 = <&gpu_opp_table>;
> iommus = <&gpu_iommu 0>;
> + #cooling-cells = <2>;
> };
>
> gpu_sram: ocmem@fdd00000 {
> @@ -98,6 +103,8 @@ Example a6xx (with GMU):
> reg = <0x5000000 0x40000>, <0x509e000 0x10>;
> reg-names = "kgsl_3d0_reg_memory", "cx_mem";
>
> + #cooling-cells = <2>;
> +
> /*
> * Look ma, no clocks! The GPU clocks and power are
> * controlled entirely by the GMU
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-10-26 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 13:14 [PATCH v2 1/3] drm/msm: Add support for GPU cooling Akhil P Oommen
2020-10-19 13:14 ` [PATCH v2 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support Akhil P Oommen
2020-10-19 13:14 ` [PATCH v2 3/3] dt-bindings: drm/msm/gpu: Add cooling device support Akhil P Oommen
2020-10-26 13:37 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026133750.GA41262@bogus \
--to=robh@kernel.org \
--cc=akhilpo@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).