From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A185C4363A for ; Tue, 27 Oct 2020 18:44:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D247D20760 for ; Tue, 27 Oct 2020 18:44:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="IACCIP29" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D247D20760 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DF9A6E202; Tue, 27 Oct 2020 18:44:49 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4FFEF6E202 for ; Tue, 27 Oct 2020 18:44:47 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id t3so116504wmi.3 for ; Tue, 27 Oct 2020 11:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=yq3mNzKnnS784nsQFC2uDIJSO3VSvUZkuyXz2yHmGdg=; b=IACCIP29UjFLYDYxCaky7/HBTtI2UNwwbCcpjcks7uKU4tAvtd5mGAnvGHmjidVDwH zP9iwtcti5gtYzQkactAV1pPQ4L2E0iotqMM1GS/1KXB6pzebnPe1RL7UfhRVRcHl7GD X8AcNVcDBhj3fsVeK3Wxl5L2lGS2fr21qPFWs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=yq3mNzKnnS784nsQFC2uDIJSO3VSvUZkuyXz2yHmGdg=; b=X1iLbaPQAgyo5f7AT1ldGJuO+5buktW2syYBTaQ57icQ6jShuxKrCNrriYzKDj5l7N pTnf5PDCNtiJjxFwS18ZUk0M0R2r3gTfATRrBKR6Or39d0NeNPKihUbJVyatZ3KlSUYO iwCOqzIScZOVsqqfl9Q7TRFschA1xgMOEVXGrezXpFtamCM5BdNZH4M/JwWSLrhEIJ6B t1saSgXHS96xBc6TY/6VPW5rqoH04GM6TerhahCQCOYlF2ggOaDG0PD3GMc+V1Ek5Zu8 wAmeiBkbWev7FDWrdmyoZ+UoZctC6HZxfcXgZKDVpHuh3GVvpCoY2JUMpyOxg8/f5DlA 02Hw== X-Gm-Message-State: AOAM531GK0wgrIwzyCa4+g/jPFkMsU6WVvlM2p4hYV8TdszBEMR0d5Z8 5A7bigP34sDGCZsSpwUJxp4I1A== X-Google-Smtp-Source: ABdhPJyNv9utLUbtl13nhVFLMe2DbQzNiipDgdzSnVahx9c+HevjO+Z5XoZ2J7OZUBZRFF03CNYYtg== X-Received: by 2002:a7b:cc09:: with SMTP id f9mr4109018wmh.93.1603824285879; Tue, 27 Oct 2020 11:44:45 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l26sm2755765wmi.41.2020.10.27.11.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 11:44:44 -0700 (PDT) Date: Tue, 27 Oct 2020 19:44:42 +0100 From: Daniel Vetter To: Peilin Ye Subject: Re: [PATCH 1/5] fbdev/atafb: Remove unused extern variables Message-ID: <20201027184442.GL401619@phenom.ffwll.local> Mail-Followup-To: Peilin Ye , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Mike Rapoport , Andrew Morton , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , Andrew Morton , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Oct 27, 2020 at 12:31:08PM -0400, Peilin Ye wrote: > Remove 6 unused extern variables to reduce confusion. It is worth > mentioning that lib/fonts/font_8x8.c and lib/fonts/font_8x16.c also > declare `fontdata_8x8` and `fontdata_8x16` respectively, and this file > has nothing to do with them. > > Signed-off-by: Peilin Ye This was unused ever since this driver was merged into 2.1.67 (I looked at historical linux git trees quickly). Save to delete I'd say, probably just copypasted from some outdated driver template that was even older. Applied to drm-misc-next. -Daniel > --- > $ # Build-tested (Ubuntu 20.04) > $ sudo apt install gcc-m68k-linux-gnu > $ cp arch/m68k/configs/atari_defconfig .config > $ make ARCH=m68k menuconfig > $ make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- -j`nproc` all > > drivers/video/fbdev/atafb.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c > index f253daa05d9d..e3812a8ff55a 100644 > --- a/drivers/video/fbdev/atafb.c > +++ b/drivers/video/fbdev/atafb.c > @@ -240,14 +240,6 @@ static int *MV300_reg = MV300_reg_8bit; > > static int inverse; > > -extern int fontheight_8x8; > -extern int fontwidth_8x8; > -extern unsigned char fontdata_8x8[]; > - > -extern int fontheight_8x16; > -extern int fontwidth_8x16; > -extern unsigned char fontdata_8x16[]; > - > /* > * struct fb_ops { > * * open/release and usage marking > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel