From: Hillf Danton <hdanton@sina.com>
To: John Stultz <john.stultz@linaro.org>
Cc: James Jones <jajones@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
Liam Mark <lmark@codeaurora.org>,
lkml <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Ezequiel Garcia <ezequiel@collabora.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v4 5/7] dma-buf: system_heap: Allocate higher order pages if available
Date: Thu, 29 Oct 2020 15:02:21 +0800 [thread overview]
Message-ID: <20201029070221.2856-1-hdanton@sina.com> (raw)
In-Reply-To: <20201029001624.17513-6-john.stultz@linaro.org>
On Thu, 29 Oct 2020 00:16:22 +0000 John Stultz wrote:
>
> +#define HIGH_ORDER_GFP (((GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN \
> + | __GFP_NORETRY) & ~__GFP_RECLAIM) \
> + | __GFP_COMP)
> +#define LOW_ORDER_GFP (GFP_HIGHUSER | __GFP_ZERO | __GFP_COMP)
> +static gfp_t order_flags[] = {HIGH_ORDER_GFP, LOW_ORDER_GFP, LOW_ORDER_GFP};
> +static const unsigned int orders[] = {8, 4, 0};
> +#define NUM_ORDERS ARRAY_SIZE(orders)
A two-line comment helps much understand the ORDERs above if it specifies the
reasons behind the detour to HPAGE_PMD_ORDER and PAGE_ALLOC_COSTLY_ORDER.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-29 8:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 0:16 [RESEND][PATCH v4 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation John Stultz
2020-10-29 0:16 ` [PATCH v4 1/7] dma-buf: system_heap: Rework system heap to use sgtables instead of pagelists John Stultz
2020-10-29 0:16 ` [PATCH v4 2/7] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation John Stultz
2020-10-29 0:16 ` [PATCH v4 3/7] dma-buf: heaps: Remove heap-helpers code John Stultz
2020-10-29 0:16 ` [PATCH v4 4/7] dma-buf: heaps: Skip sync if not mapped John Stultz
2020-10-29 0:16 ` [PATCH v4 5/7] dma-buf: system_heap: Allocate higher order pages if available John Stultz
2020-10-29 7:02 ` Hillf Danton [this message]
2020-10-29 19:34 ` John Stultz
2020-10-29 0:16 ` [PATCH v4 6/7] dma-buf: dma-heap: Keep track of the heap device struct John Stultz
2020-10-29 0:16 ` [PATCH v4 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap John Stultz
2020-10-29 7:10 ` Hillf Danton
2020-10-29 22:28 ` John Stultz
-- strict thread matches above, loose matches on Subject: below --
2020-10-30 2:34 [PATCH v4 5/7] dma-buf: system_heap: Allocate higher order pages if available Hillf Danton
2020-10-30 3:30 ` John Stultz
2020-10-17 1:32 [PATCH v4 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation John Stultz
2020-10-17 1:32 ` [PATCH v4 5/7] dma-buf: system_heap: Allocate higher order pages if available John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029070221.2856-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ezequiel@collabora.com \
--cc=jajones@nvidia.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox