dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Jason Gunthorpe <jgg@nvidia.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [drm-drm-misc:for-linux-next 2/2] drivers/dma-buf/dma-buf.c:1186: undefined reference to `vma_set_file'
Date: Thu, 5 Nov 2020 17:02:09 +0100	[thread overview]
Message-ID: <20201105160209.GA401619@phenom.ffwll.local> (raw)
In-Reply-To: <3687eb25-8c94-4a08-9917-0f12d57ba76c@amd.com>

On Thu, Nov 05, 2020 at 04:41:00PM +0100, Christian König wrote:
> Guys, can anybody help me out. Why is the kernel test robot complaining
> here?
> 
> Thanks in advance,
> Christian.
> 
> Am 05.11.20 um 16:26 schrieb kernel test robot:
> > tree:   git://anongit.freedesktop.org/drm/drm-misc for-linux-next
> > head:   2b5b95b1ff3d70a95013a45e3b5b90f1daf42348
> > commit: 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348 [2/2] mm: introduce vma_set_file function v4
> > config: h8300-randconfig-r031-20201105 (attached as .config)
> > compiler: h8300-linux-gcc (GCC) 9.3.0

nommu platform?

If you have a hard time finding a cross compiler for this, there's some
nommu arm platforms. I used that for compile teesting nommu support
recently.

If it's not that, then it's something specific with that config for sure.
-Daniel

> > reproduce (this is a W=1 build):
> >          wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7C2c3b39afc651426aa50608d8819f48fc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637401871204724096%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=dK2txO1WerkR7SiB5i9kcXjbJTMlaQ1Q6dbK1cb9lnE%3D&amp;reserved=0 -O ~/bin/make.cross
> >          chmod +x ~/bin/make.cross
> >          git remote add drm-drm-misc git://anongit.freedesktop.org/drm/drm-misc
> >          git fetch --no-tags drm-drm-misc for-linux-next
> >          git checkout 2b5b95b1ff3d70a95013a45e3b5b90f1daf42348
> >          # save the attached .config to linux build tree
> >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >     h8300-linux-ld: section .init.text LMA [00000000004da400,000000000051ebcb] overlaps section .text LMA [000000000000025c,0000000001069997]
> >     h8300-linux-ld: section .data VMA [0000000000400000,00000000004da3ff] overlaps section .text VMA [000000000000025c,0000000001069997]
> >     h8300-linux-ld: drivers/dma-buf/dma-buf.o: in function `dma_buf_mmap':
> > > > drivers/dma-buf/dma-buf.c:1186: undefined reference to `vma_set_file'
> > vim +1186 drivers/dma-buf/dma-buf.c
> > 
> >    1150	
> >    1151	
> >    1152	/**
> >    1153	 * dma_buf_mmap - Setup up a userspace mmap with the given vma
> >    1154	 * @dmabuf:	[in]	buffer that should back the vma
> >    1155	 * @vma:	[in]	vma for the mmap
> >    1156	 * @pgoff:	[in]	offset in pages where this mmap should start within the
> >    1157	 *			dma-buf buffer.
> >    1158	 *
> >    1159	 * This function adjusts the passed in vma so that it points at the file of the
> >    1160	 * dma_buf operation. It also adjusts the starting pgoff and does bounds
> >    1161	 * checking on the size of the vma. Then it calls the exporters mmap function to
> >    1162	 * set up the mapping.
> >    1163	 *
> >    1164	 * Can return negative error values, returns 0 on success.
> >    1165	 */
> >    1166	int dma_buf_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma,
> >    1167			 unsigned long pgoff)
> >    1168	{
> >    1169		if (WARN_ON(!dmabuf || !vma))
> >    1170			return -EINVAL;
> >    1171	
> >    1172		/* check if buffer supports mmap */
> >    1173		if (!dmabuf->ops->mmap)
> >    1174			return -EINVAL;
> >    1175	
> >    1176		/* check for offset overflow */
> >    1177		if (pgoff + vma_pages(vma) < pgoff)
> >    1178			return -EOVERFLOW;
> >    1179	
> >    1180		/* check for overflowing the buffer's size */
> >    1181		if (pgoff + vma_pages(vma) >
> >    1182		    dmabuf->size >> PAGE_SHIFT)
> >    1183			return -EINVAL;
> >    1184	
> >    1185		/* readjust the vma */
> > > 1186		vma_set_file(vma, dmabuf->file);
> >    1187		vma->vm_pgoff = pgoff;
> >    1188	
> >    1189		return dmabuf->ops->mmap(dmabuf, vma);
> >    1190	}
> >    1191	EXPORT_SYMBOL_GPL(dma_buf_mmap);
> >    1192	
> > 
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7C2c3b39afc651426aa50608d8819f48fc%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637401871204724096%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=YS8NkL2Wf4ysbsibG3a3MAGp8zsEopbazO3ARSAPezc%3D&amp;reserved=0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-11-05 16:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <202011052343.iOH9oZPH-lkp@intel.com>
2020-11-05 15:41 ` [drm-drm-misc:for-linux-next 2/2] drivers/dma-buf/dma-buf.c:1186: undefined reference to `vma_set_file' Christian König
2020-11-05 16:02   ` Daniel Vetter [this message]
2020-11-05 16:04     ` Daniel Vetter
2020-11-05 16:05       ` Christian König
2020-11-05 16:15         ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105160209.GA401619@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jgg@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox