From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30648C55ABD for ; Wed, 11 Nov 2020 16:33:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A146206F1 for ; Wed, 11 Nov 2020 16:33:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="VI4UXpTi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A146206F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD7AA6E05C; Wed, 11 Nov 2020 16:33:29 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DE546E05C for ; Wed, 11 Nov 2020 16:33:28 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id b6so3140888wrt.4 for ; Wed, 11 Nov 2020 08:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ga1fyMAmNUTSAvvb86TLuTih6D60seEP1BnyyhlHnYY=; b=VI4UXpTiZEN7+z8Qsv+0gCYkKZSww1tSQBsYAMTn9aZ7M4Tb81ahQaNnpGcqmshf+K 8vJ0own2MMoy57ODOpq6SRaIs7ySMgIz+lKmFFbsfxytru7SQLeMGkCYCTr3aNTDXLqU 5YAL3Y72T2gPzTHtH4AUS8xraIsFgCbe/jX0A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ga1fyMAmNUTSAvvb86TLuTih6D60seEP1BnyyhlHnYY=; b=gULscKU3Px7BMrj1mdsuAJ63cw4/nxRf2UYiFx7E+4TuyvoEy2YBkox/XWy4gEBDcL l2wpdnJHWRn+4rxZSGoKJOzWGRZitXY+mFozDyCNMrfelwm0lp9E8rQM3wbzmFyeO4MQ WBn5+ts8shMRAMwpdaqmz8dgWjLVg37CwQAgwXCeYAm2CiM/EhhbwmmUymoLsVylK9J0 d1VukRfZWJuM3W69g3xpVxVMSB+MlstW733NQVy0C9G8gTJmX44zrS9IUexZWYaSEfLX 79PMECIcN0pl2kl36UxD1OKxFRFh88FVUlbCf2e32HjAf6F/GUBNcP0Df9BPqF++v7bH Qu0w== X-Gm-Message-State: AOAM532lOlRgYjcJio7DpWKMmTLVMK/3YcSIiteknTUAcga053r3oDDJ DYEgsJNGUx/eDHDZ+tyI/lEREA== X-Google-Smtp-Source: ABdhPJwVnaxroRTsLEh40OxFCTehh6Vn65sqL0FGpXCgNjn6gajinA4J5yHz8TCOoRmujGffihQ/8A== X-Received: by 2002:adf:9d44:: with SMTP id o4mr32746496wre.229.1605112406900; Wed, 11 Nov 2020 08:33:26 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id f19sm3030443wml.21.2020.11.11.08.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 08:33:25 -0800 (PST) Date: Wed, 11 Nov 2020 17:33:23 +0100 From: Daniel Vetter To: Jianxin Xiong Subject: Re: [PATCH v10 6/6] dma-buf: Document that dma-buf size is fixed Message-ID: <20201111163323.GP401619@phenom.ffwll.local> References: <1605044477-51833-1-git-send-email-jianxin.xiong@intel.com> <1605044477-51833-7-git-send-email-jianxin.xiong@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1605044477-51833-7-git-send-email-jianxin.xiong@intel.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leon Romanovsky , linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, Jason Gunthorpe , Doug Ledford , Daniel Vetter , Christian Koenig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Nov 10, 2020 at 01:41:17PM -0800, Jianxin Xiong wrote: > The fact that the size of dma-buf is invariant over the lifetime of the > buffer is mentioned in the comment of 'dma_buf_ops.mmap', but is not > documented at where the info is defined. Add the missing documentation. > > Signed-off-by: Jianxin Xiong Applied to drm-misc-next, thanks for your patch. For the preceeding dma-buf patch I'll wait for more review/acks before I apply it. Ack from Jason might also be good, since looks like this dma_virt_ops is only used in rdma. -Daniel > --- > include/linux/dma-buf.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index 9dcd569..92da98b 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -272,7 +272,7 @@ struct dma_buf_ops { > > /** > * struct dma_buf - shared buffer object > - * @size: size of the buffer > + * @size: size of the buffer; invariant over the lifetime of the buffer. > * @file: file pointer used for sharing buffers across, and for refcounting. > * @attachments: list of dma_buf_attachment that denotes all devices attached, > * protected by dma_resv lock. > @@ -404,7 +404,7 @@ struct dma_buf_attachment { > * @exp_name: name of the exporter - useful for debugging. > * @owner: pointer to exporter module - used for refcounting kernel module > * @ops: Attach allocator-defined dma buf ops to the new buffer > - * @size: Size of the buffer > + * @size: Size of the buffer - invariant over the lifetime of the buffer > * @flags: mode flags for the file > * @resv: reservation-object, NULL to allocate default one > * @priv: Attach private data of allocator to this buffer > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel