From: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
To: Gurchetan Singh <gurchetansingh@chromium.org>
Cc: kraxel@redhat.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/virtio: use fence_id when processing fences
Date: Fri, 20 Nov 2020 10:23:21 +0100 [thread overview]
Message-ID: <20201120092321.GA12906@gmail.com> (raw)
In-Reply-To: <20201119010809.528-4-gurchetansingh@chromium.org>
On Wed, Nov 18, 2020 at 05:08:08PM -0800, Gurchetan Singh wrote:
>Currently, the fence ID, which can be used to identify a
>virtgpu fence, is the same as the fence sequence number.
>
>Let's use the fence_id name to clearly signal this.
>
>Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
>---
> drivers/gpu/drm/virtio/virtgpu_drv.h | 2 +-
> drivers/gpu/drm/virtio/virtgpu_fence.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h
>index c94052376d18..7c7967a2eb84 100644
>--- a/drivers/gpu/drm/virtio/virtgpu_drv.h
>+++ b/drivers/gpu/drm/virtio/virtgpu_drv.h
>@@ -420,7 +420,7 @@ void virtio_gpu_fence_emit(struct virtio_gpu_device *vgdev,
> struct virtio_gpu_ctrl_hdr *cmd_hdr,
> struct virtio_gpu_fence *fence);
> void virtio_gpu_fence_event_process(struct virtio_gpu_device *vdev,
>- u64 last_seq);
>+ u64 fence_id);
>
> /* virtgpu_object.c */
> void virtio_gpu_cleanup_object(struct virtio_gpu_object *bo);
>diff --git a/drivers/gpu/drm/virtio/virtgpu_fence.c b/drivers/gpu/drm/virtio/virtgpu_fence.c
>index 5b2a4146c5bd..2fe9c7ebcbd4 100644
>--- a/drivers/gpu/drm/virtio/virtgpu_fence.c
>+++ b/drivers/gpu/drm/virtio/virtgpu_fence.c
>@@ -112,16 +112,16 @@ void virtio_gpu_fence_emit(struct virtio_gpu_device *vgdev,
> }
>
> void virtio_gpu_fence_event_process(struct virtio_gpu_device *vgdev,
>- u64 last_seq)
>+ u64 fence_id)
> {
> struct virtio_gpu_fence_driver *drv = &vgdev->fence_drv;
> struct virtio_gpu_fence *fence, *tmp;
> unsigned long irq_flags;
>
> spin_lock_irqsave(&drv->lock, irq_flags);
>- atomic64_set(&vgdev->fence_drv.last_seq, last_seq);
>+ atomic64_set(&vgdev->fence_drv.last_seq, fence_id);
> list_for_each_entry_safe(fence, tmp, &drv->fences, node) {
>- if (last_seq < fence->f.seqno)
>+ if (fence_id < fence->f.seqno)
> continue;
> dma_fence_signal_locked(&fence->f);
> list_del(&fence->node);
>--
>2.29.2.299.gdc1121823c-goog
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-20 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 1:08 [PATCH 1/5] drm/virtio: suffix create blob call with _ioctl like any ioctl Gurchetan Singh
2020-11-19 1:08 ` [PATCH 2/5] drm/virtio: fix a file name comment reference Gurchetan Singh
2020-11-19 1:08 ` [PATCH 3/5] virtio-gpu api: Add a comment on VIRTIO_GPU_SHM_ID_HOST_VISIBLE Gurchetan Singh
2020-11-19 1:08 ` [PATCH 4/5] drm/virtio: use fence_id when processing fences Gurchetan Singh
2020-11-20 9:23 ` Anthoine Bourgeois [this message]
2020-11-19 1:08 ` [PATCH 5/5] drm/virtio: rename sync_seq and last_seq Gurchetan Singh
2020-11-20 9:24 ` Anthoine Bourgeois
2020-11-20 11:09 ` [PATCH 1/5] drm/virtio: suffix create blob call with _ioctl like any ioctl Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120092321.GA12906@gmail.com \
--to=anthoine.bourgeois@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=kraxel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox