From: Sam Ravnborg <sam@ravnborg.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: alsa-devel@alsa-project.org, bridge@lists.linux-foundation.org,
linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
linux-ide@vger.kernel.org, dm-devel@redhat.com,
keyrings@vger.kernel.org, linux-mtd@lists.infradead.org,
GR-everest-linux-l2@marvell.com, wcn36xx@lists.infradead.org,
linux-i3c@lists.infradead.org,
linux1394-devel@lists.sourceforge.net,
linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com,
devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
rds-devel@oss.oracle.com, linux-scsi@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-rdma@vger.kernel.org,
oss-drivers@netronome.com,
linux-atm-general@lists.sourceforge.net,
ceph-devel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-stm32@st-md-mailman.stormreply.com,
cluster-devel@redhat.com, usb-storage@lists.one-eyed-alien.net,
coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-input@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
linux-ext4@vger.kernel.org, netfilter-devel@vger.kernel.org,
linux-media@vger.kernel.org, linux-usb@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
selinux@vger.kernel.org, linux-arm-msm@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-sctp@vger.kernel.org,
reiserfs-devel@vger.kernel.org, linux-geode@lists.infradead.org,
linux-block@vger.kernel.org, linux-gpio@vger.kernel.org,
op-tee@lists.trustedfirmware.org,
linux-mediatek@lists.infradead.org,
xen-devel@lists.xenproject.org, nouveau@lists.freedesktop.org,
linux-hams@vger.kernel.org,
Nathan Chancellor <natechancellor@gmail.com>,
linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
linux-watchdog@vger.kernel.org, GR-Linux-NIC-Dev@marvell.com,
linux-mm@kvack.org, netdev@vger.kernel.org,
linux-decnet-user@lists.sourceforge.net,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-security-module@vger.kernel.org,
target-devel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, patches@opensource.cirrus.com,
Joe Perches <joe@perches.com>,
linux-integrity@vger.kernel.org, linux-nfs@vger.kernel.org,
x86@kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 000/141] Fix fall-through warnings for Clang
Date: Sun, 22 Nov 2020 23:10:40 +0100 [thread overview]
Message-ID: <20201122221040.GD566387@ravnborg.org> (raw)
In-Reply-To: <9b57fd4914b46f38d54087d75e072d6e947cb56d.camel@HansenPartnership.com>
Hi James.
> > > If none of the 140 patches here fix a real bug, and there is no
> > > change to machine code then it sounds to me like a W=2 kind of a
> > > warning.
> >
> > FWIW, this series has found at least one bug so far:
> > https://lore.kernel.org/lkml/CAFCwf11izHF=g1mGry1fE5kvFFFrxzhPSM6qKAO8gxSp=Kr_CQ@mail.gmail.com/
>
>
> Well, it's a problem in an error leg, sure, but it's not a really
> compelling reason for a 141 patch series, is it? All that fixing this
> error will do is get the driver to print "oh dear there's a problem"
> under four more conditions than it previously did.
You are asking the wrong question here.
Yuo should ask how many hours could have been saved by all the bugs
people have been fighting with and then fixed *before* the code
hit the kernel at all.
My personal experience is that I, more than once, have had errors
related to a missing break in my code. So this warnings is IMO a win.
And if we are only ~100 patches to have it globally enabled then it is a
no-brainer in my book.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-22 22:10 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 18:21 [PATCH 000/141] Fix fall-through warnings for Clang Gustavo A. R. Silva
2020-11-20 18:24 ` [PATCH 004/141] drm/amdgpu: " Gustavo A. R. Silva
2020-11-20 22:42 ` Alex Deucher
2020-11-23 22:42 ` Gustavo A. R. Silva
2020-11-20 18:24 ` [PATCH 005/141] drm/radeon: " Gustavo A. R. Silva
2020-11-20 22:43 ` Alex Deucher
2020-11-20 18:28 ` [PATCH 028/141] drm/amd/display: " Gustavo A. R. Silva
2020-11-20 22:45 ` Alex Deucher
2020-11-23 22:47 ` Gustavo A. R. Silva
2020-11-20 18:28 ` [PATCH 000/141] " Joe Perches
2020-11-20 19:02 ` Gustavo A. R. Silva
2020-11-20 18:35 ` [PATCH 078/141] drm/amd/pm: " Gustavo A. R. Silva
2020-11-20 22:46 ` Alex Deucher
2020-11-20 18:35 ` [PATCH 079/141] drm: " Gustavo A. R. Silva
2020-11-22 22:03 ` Sam Ravnborg
2020-11-23 22:57 ` Gustavo A. R. Silva
2020-11-20 18:35 ` [PATCH 080/141] drm/i915/gem: " Gustavo A. R. Silva
2020-11-20 18:35 ` [PATCH 081/141] drm/nouveau/clk: " Gustavo A. R. Silva
2020-11-20 18:35 ` [PATCH 082/141] drm/nouveau: " Gustavo A. R. Silva
2020-11-20 18:35 ` [PATCH 083/141] drm/nouveau/therm: " Gustavo A. R. Silva
2020-11-20 18:35 ` [PATCH 084/141] drm/via: " Gustavo A. R. Silva
2020-11-22 22:03 ` Sam Ravnborg
2020-11-24 14:34 ` Gustavo A. R. Silva
2020-11-20 18:40 ` [PATCH 134/141] video: fbdev: lxfb_ops: " Gustavo A. R. Silva
2020-11-22 22:05 ` Sam Ravnborg
2020-11-24 14:44 ` Gustavo A. R. Silva
2020-11-20 18:40 ` [PATCH 135/141] video: fbdev: pm2fb: " Gustavo A. R. Silva
2020-11-20 18:53 ` [PATCH 000/141] " Jakub Kicinski
2020-11-20 19:04 ` Gustavo A. R. Silva
2020-11-20 19:30 ` Kees Cook
2020-11-20 19:51 ` Jakub Kicinski
2020-11-20 20:48 ` Kees Cook
2020-11-22 16:17 ` Kees Cook
2020-11-22 18:21 ` James Bottomley
2020-11-22 18:25 ` Joe Perches
2020-11-22 19:12 ` James Bottomley
2020-11-22 19:22 ` Joe Perches
2020-11-22 19:53 ` James Bottomley
2020-11-23 13:03 ` [Intel-wired-lan] " Gustavo A. R. Silva
2020-11-23 16:31 ` James Bottomley
2020-11-24 21:32 ` Kees Cook
2020-11-24 22:24 ` Finn Thain
2020-11-24 23:15 ` Miguel Ojeda
2020-11-24 23:53 ` Finn Thain
2020-11-25 1:05 ` Miguel Ojeda
2020-11-25 7:05 ` James Bottomley
2020-11-25 12:24 ` Nick Desaulniers
2020-11-25 16:24 ` Jakub Kicinski
2020-11-25 17:04 ` Miguel Ojeda
2020-11-25 22:09 ` Nick Desaulniers
2020-11-25 21:33 ` Finn Thain
2020-11-25 22:09 ` Nick Desaulniers
2020-11-25 23:21 ` Finn Thain
2020-11-26 0:30 ` Finn Thain
2020-11-25 21:10 ` Kees Cook
2020-11-22 20:35 ` Miguel Ojeda
2020-11-22 22:36 ` James Bottomley
2020-11-23 14:19 ` Miguel Ojeda
2020-11-23 15:58 ` James Bottomley
2020-11-23 16:24 ` Rafael J. Wysocki
2020-11-23 16:32 ` Joe Perches
2020-11-23 18:56 ` Miguel Ojeda
2020-11-23 20:37 ` James Bottomley
2020-11-25 0:32 ` Miguel Ojeda
2020-11-25 22:44 ` Edward Cree
2020-11-26 14:53 ` Miguel Ojeda
2020-11-26 15:28 ` Geert Uytterhoeven
2020-11-26 16:18 ` Karol Herbst
2020-11-26 17:05 ` Miguel Ojeda
2020-11-25 10:38 ` Andy Shevchenko
2020-11-25 9:01 ` Sean Young
[not found] ` <alpine.LNX.2.23.453.2011230938390.7@nippy.intranet>
2020-11-22 23:04 ` James Bottomley
2020-11-23 14:05 ` Miguel Ojeda
2020-11-24 0:58 ` Finn Thain
2020-11-24 1:05 ` Joe Perches
2020-11-24 2:48 ` Finn Thain
2020-11-24 23:46 ` Miguel Ojeda
2020-11-22 22:10 ` Sam Ravnborg [this message]
2020-11-24 1:32 ` Nick Desaulniers
2020-11-24 1:46 ` Jakub Kicinski
2020-11-24 21:25 ` Kees Cook
2020-11-25 23:02 ` Edward Cree
2020-12-01 14:08 ` Dan Carpenter
2020-12-01 14:04 ` Dan Carpenter
2020-11-20 22:21 ` Miguel Ojeda
2020-11-23 20:03 ` Jason Gunthorpe
2020-11-24 14:47 ` Gustavo A. R. Silva
2020-11-23 20:38 ` Mark Brown
2020-11-24 14:47 ` Gustavo A. R. Silva
2020-12-01 5:52 ` Martin K. Petersen
2020-12-01 8:20 ` Gustavo A. R. Silva
2020-12-08 4:52 ` (subset) " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201122221040.GD566387@ravnborg.org \
--to=sam@ravnborg.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bridge@lists.linux-foundation.org \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=coreteam@netfilter.org \
--cc=devel@driverdev.osuosl.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=oss-drivers@netronome.com \
--cc=patches@opensource.cirrus.com \
--cc=rds-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=selinux@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=wcn36xx@lists.infradead.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).