dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: Melissa Wen <melissa.srw@gmail.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
	Leandro Ribeiro <leandro.ribeiro@collabora.com>
Subject: Re: [PATCH] drm/vkms: detect modes during output initialization
Date: Mon, 30 Nov 2020 13:13:26 +0200	[thread overview]
Message-ID: <20201130131326.7ac87605@eldfell> (raw)
In-Reply-To: <H5TtDGvtYXHmWmVpmi1NyWShzr17yAkVlxZOuKcP-fekJpvYX_Ec7JQtizWk8Xpkaw95TIkTqhzWZER4xwl0mOguSjIQSGLBgGQVMPAejyY=@emersion.fr>


[-- Attachment #1.1: Type: text/plain, Size: 1096 bytes --]

On Mon, 30 Nov 2020 10:23:04 +0000
Simon Ser <contact@emersion.fr> wrote:

> On Monday, November 30, 2020 2:03 AM, Leandro Ribeiro <leandro.ribeiro@collabora.com> wrote:
> 
> > In userspace we can use drmGetConnector() or drmGetConnectorCurrent() in
> > order to retrieve connector information. The difference between both is
> > that the former retrieves the complete set of modes and encoders
> > associated with the connector, while the latter only retrieves the
> > currently known set of modes and encoders - but is much faster.
> >
> > This performance improvement is the reason why userspace applications
> > may prefer to use drmGetConnectorCurrent() when they need to retrieve
> > information from a device.  
> 
> We discussed with Daniel Vetter and it turns out user-space should
> always use drmGetConnector(). See [1].

Hi, 

where is the discussion?

> [1]: https://lists.freedesktop.org/archives/dri-devel/2020-November/289506.html

Please record the justitication for that patch in its commit message.
"Can't" does not explain anything.


Thanks,
pq

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-11-30 11:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 16:19 [BUG] drm/vkms: Failure when using drmGetConnectorCurrent() Leandro Ribeiro
2020-11-24 14:39 ` Daniel Vetter
2020-11-27 20:31   ` Leandro Ribeiro
2020-11-27 21:10   ` [PATCH] drm/vkms: detect modes during output initialization Leandro Ribeiro
2020-11-27 21:16     ` Leandro Ribeiro
2020-11-30 10:23     ` Simon Ser
2020-11-30 11:13       ` Pekka Paalanen [this message]
2020-11-30 11:16         ` Simon Ser
2020-11-30 11:24           ` Pekka Paalanen
2020-11-30 12:20             ` Simon Ser
2020-12-01  8:46               ` Pekka Paalanen
2020-12-01  8:55                 ` Simon Ser
2020-12-01  2:24     ` [drm/vkms] b6c9ddb8c4: WARNING:at_drivers/gpu/drm/drm_probe_helper.c:#drm_helper_probe_single_connector_modes kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201130131326.7ac87605@eldfell \
    --to=ppaalanen@gmail.com \
    --cc=contact@emersion.fr \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=leandro.ribeiro@collabora.com \
    --cc=melissa.srw@gmail.com \
    --cc=rodrigosiqueiramelo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox