From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE48C64E7A for ; Tue, 1 Dec 2020 20:28:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90E45206E0 for ; Tue, 1 Dec 2020 20:28:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90E45206E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 274D56E02B; Tue, 1 Dec 2020 20:28:39 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 485BD6E02B for ; Tue, 1 Dec 2020 20:28:38 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id C52D72001F; Tue, 1 Dec 2020 21:28:34 +0100 (CET) Date: Tue, 1 Dec 2020 21:28:33 +0100 From: Sam Ravnborg To: Doug Anderson Subject: Re: [PATCH] drm: panel: add flags to BOE NV110WTM-N61 Message-ID: <20201201202833.GA2040622@ravnborg.org> References: <20201130182643.GA1497637@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=cm27Pg_UAAAA:8 a=pGLkceISAAAA:8 a=e5mUnYsNAAAA:8 a=DW601nYS4FH9a570c1EA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=xmb-EsYY8bH0VWELuYED:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thierry Reding , dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Doug, On Tue, Dec 01, 2020 at 10:53:17AM -0800, Doug Anderson wrote: > Hi, > > On Mon, Nov 30, 2020 at 10:26 AM Sam Ravnborg wrote: > > > > When applying a patch to add the BOE NV110WTM-N61 panel I forgot > > to add the changes that added flags to drm_display_mode. > > Sorry, I didn't mean to make more work for you! > > > > Signed-off-by: Sam Ravnborg > > Fixes: a96ee0f6b58d ("drm: panel: simple: Add BOE NV110WTM-N61") > > Cc: Douglas Anderson > > Cc: Sam Ravnborg > > Cc: Thierry Reding > > Cc: dri-devel@lists.freedesktop.org > > --- > > drivers/gpu/drm/panel/panel-simple.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 216cde33b5c4..2d093b5a513c 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -1367,6 +1367,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = { > > .vsync_start = 800 + 3, > > .vsync_end = 800 + 3 + 5, > > .vtotal = 800 + 3 + 5 + 24, > > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC, > > }, > > { > > .clock = 57500, > > @@ -1378,6 +1379,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = { > > .vsync_start = 800 + 3, > > .vsync_end = 800 + 3 + 5, > > .vtotal = 800 + 3 + 5 + 24, > > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC, > > I think you're off by 10 and a letter. > > The subject talks about: > NV110WTM-N61 > > You're modifying the structs for: > NV101WXM-N51 > > I'm happy to post this if it's helpful to you, or I can review a v2 > from you. :-) Please do so, that would be very nice. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel