From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Stephan Gerhold <stephan@gerhold.net>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: s6e63m0: Fix init sequence again
Date: Sat, 5 Dec 2020 14:26:50 +0100 [thread overview]
Message-ID: <20201205132650.GA301178@ravnborg.org> (raw)
In-Reply-To: <20201205122229.1952980-1-linus.walleij@linaro.org>
Hi Linus
On Sat, Dec 05, 2020 at 01:22:29PM +0100, Linus Walleij wrote:
> The DSI version of the panel behaved instable and close
> scrutiny of the vendor driver from the Samsung
> GT-S8190 shows a different initialization sequence for
> the DSI mode panel than the DPI mode panel.
>
> Make the initialization depend on whether we are in
> DSI or DPI mode and handle the differences.
>
> After this the panel on the GT-I8190 becomes much more
> stable.
>
> Also spell out some more custom DCS commands found in
> the vendor source code to cut down a bit on magic
> where we can.
>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Fixes: f0aee45ffc8b ("drm/panel: s6e63m0: Fix init sequence")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Looks good - the extra defines reduces the magic a little which is good.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-12-05 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 12:22 [PATCH] drm/panel: s6e63m0: Fix init sequence again Linus Walleij
2020-12-05 13:26 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205132650.GA301178@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).