Re: [PATCH] drm/vboxvideo: Used the vram helper

From: kernel test robot <lkp@intel.com>
To: Tian Tao <tiantao6@hisilicon.com>,
	hdegoede@redhat.com, airlied@linux.ie, daniel@ffwll.ch
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/vboxvideo: Used the vram helper
Date: Tue, 8 Dec 2020 05:31:13 +0800	[thread overview]
Message-ID: <202012080510.l7JSbfDQ-lkp@intel.com> (raw)
In-Reply-To: <1606446882-36335-1-git-send-email-tiantao6@hisilicon.com>

[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]

Hi Tian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.10-rc7 next-20201207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tian-Tao/drm-vboxvideo-Used-the-vram-helper/20201127-112000
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 85a2c56cb4454c73f56d3099d96942e7919b292f
config: i386-randconfig-r031-20201207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/f3abc53a9794f39d04b604a243d28be17a88571f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tian-Tao/drm-vboxvideo-Used-the-vram-helper/20201127-112000
        git checkout f3abc53a9794f39d04b604a243d28be17a88571f
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/vboxvideo/vbox_ttm.c: In function 'vbox_mm_init':
>> drivers/gpu/drm/vboxvideo/vbox_ttm.c:19:6: warning: assignment to 'struct drm_vram_mm *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      19 |  vmm = drmm_vram_helper_init(dev, pci_resource_start(dev->pdev, 0),
         |      ^

vim +19 drivers/gpu/drm/vboxvideo/vbox_ttm.c

    12	
    13	int vbox_mm_init(struct vbox_private *vbox)
    14	{
    15		struct drm_vram_mm *vmm;
    16		int ret;
    17		struct drm_device *dev = &vbox->ddev;
    18	
  > 19		vmm = drmm_vram_helper_init(dev, pci_resource_start(dev->pdev, 0),
    20					    vbox->available_vram_size);
    21		if (IS_ERR(vmm)) {
    22			ret = PTR_ERR(vmm);
    23			DRM_ERROR("Error initializing VRAM MM; %d\n", ret);
    24			return ret;
    25		}
    26	
    27		vbox->fb_mtrr = arch_phys_wc_add(pci_resource_start(dev->pdev, 0),
    28						 pci_resource_len(dev->pdev, 0));
    29		return 0;
    30	}
    31	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37296 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel