From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B07B5C4361B for ; Tue, 8 Dec 2020 18:48:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3450223B51 for ; Tue, 8 Dec 2020 18:48:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3450223B51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8953C89A98; Tue, 8 Dec 2020 18:48:40 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 959AA894A7 for ; Tue, 8 Dec 2020 18:48:39 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 9B4BA804FC; Tue, 8 Dec 2020 19:48:37 +0100 (CET) Date: Tue, 8 Dec 2020 19:48:36 +0100 From: Sam Ravnborg To: Philipp Zabel Subject: Re: [PATCH v4 01/19] drm/encoder: make encoder control functions optional Message-ID: <20201208184836.GA165851@ravnborg.org> References: <20201208155451.8421-1-p.zabel@pengutronix.de> <20201208155451.8421-2-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201208155451.8421-2-p.zabel@pengutronix.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Itgwjo3g c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=P1BnusSwAAAA:8 a=7gkXJVJtAAAA:8 a=gXE83F-jS_NvKnHU4g4A:9 a=CjuIK1q_8ugA:10 a=D0XLA9XvdZm18NrgonBM:22 a=E9Po1WZjFZOl8hwRPBS3:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org, Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Philipp, On Tue, Dec 08, 2020 at 04:54:33PM +0100, Philipp Zabel wrote: > Simple managed encoders do not require the .destroy callback, > make the whole funcs structure optional. > > Signed-off-by: Philipp Zabel > Reviewed-by: Laurent Pinchart > --- > New in v4. > --- > drivers/gpu/drm/drm_encoder.c | 4 ++-- > drivers/gpu/drm/drm_mode_config.c | 5 +++-- > include/drm/drm_encoder.h | 2 +- > 3 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_encoder.c b/drivers/gpu/drm/drm_encoder.c > index e555281f43d4..b0b86a3c08f5 100644 > --- a/drivers/gpu/drm/drm_encoder.c > +++ b/drivers/gpu/drm/drm_encoder.c > @@ -72,7 +72,7 @@ int drm_encoder_register_all(struct drm_device *dev) > int ret = 0; > > drm_for_each_encoder(encoder, dev) { > - if (encoder->funcs->late_register) > + if (encoder->funcs && encoder->funcs->late_register) > ret = encoder->funcs->late_register(encoder); > if (ret) > return ret; > @@ -86,7 +86,7 @@ void drm_encoder_unregister_all(struct drm_device *dev) > struct drm_encoder *encoder; > > drm_for_each_encoder(encoder, dev) { > - if (encoder->funcs->early_unregister) > + if (encoder->funcs && encoder->funcs->early_unregister) > encoder->funcs->early_unregister(encoder); > } > } > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > index f1affc1bb679..87e144155456 100644 > --- a/drivers/gpu/drm/drm_mode_config.c > +++ b/drivers/gpu/drm/drm_mode_config.c > @@ -195,7 +195,7 @@ void drm_mode_config_reset(struct drm_device *dev) > crtc->funcs->reset(crtc); > > drm_for_each_encoder(encoder, dev) > - if (encoder->funcs->reset) > + if (encoder->funcs && encoder->funcs->reset) > encoder->funcs->reset(encoder); > > drm_connector_list_iter_begin(dev, &conn_iter); > @@ -487,7 +487,8 @@ void drm_mode_config_cleanup(struct drm_device *dev) > > list_for_each_entry_safe(encoder, enct, &dev->mode_config.encoder_list, > head) { > - encoder->funcs->destroy(encoder); > + if (encoder->funcs) > + encoder->funcs->destroy(encoder); So late_register and early_unregister are both optional. But if encoder->funcs is set then the destroy callback is mandatory. I am just wondering if this is intended. Reding the documnetation of drm_encoder_funcs thist matches the documentation but anyway.. With this comment considered, Reviewed-by: Sam Ravnborg _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel