From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C2CC4361B for ; Wed, 9 Dec 2020 00:48:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63B13238E5 for ; Wed, 9 Dec 2020 00:48:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63B13238E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE5836E204; Wed, 9 Dec 2020 00:48:33 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ED4A6E204 for ; Wed, 9 Dec 2020 00:48:32 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id a12so160631wrv.8 for ; Tue, 08 Dec 2020 16:48:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ox5zQISWwNrJYCnv3rEN+/KGNGz8F1piSUSaeuA2Q3I=; b=bHVjRyMZ0VeHC3si/pP0OMe1oFzKs7I81FuHfido5pN9wn7PUofGne0IIZaH5o2sab pwTIwHSE6jd3pHBOzv6zK3g1CWJRy89bx4omDlpbn0puAvI+gBVm+Gz+0RvFbriXhPep 9XnGYaRlinXQos1aTJUEktZUSASEVqaczsfJU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ox5zQISWwNrJYCnv3rEN+/KGNGz8F1piSUSaeuA2Q3I=; b=YSb07ramsjvegDCBeKvZzw2eZ3Gy3cZ5BXG0tYS7g68a2mM2la0Y1jRBQNH7jNpnb5 6RP8O3zfIPhTmowpdg9bvfoxoSDEe39TxPsnirwv7TqiUmds2ILjOYAG+ivCvvtBG9AI C9UU+A4ZoB+9R4hX2f38+KmHxrno2UAemmbWiDYwjleEkvD4ylsEbe1YqgpTyodquS6O CfUPmvTbRvkg7Qcl1/rQy2QVlnGjzD4lq/0USP98ci5w9gshXG4uvAlhJe/ZqnOo2mOZ m/WNAzgD8I/xIjLqVzRMMVShO2q8RYGcMoQcd2zwGGfGSeV7rt124e9/TzBvgjcLwfRC uNyg== X-Gm-Message-State: AOAM5308Ui8FKagMsS8DZNc2uI3VlpmUMGYWfUjfAzJ1WFoGbD3iHerf D5eZEKsJrj5OSHJdTojDap/kZw== X-Google-Smtp-Source: ABdhPJxjYKFlYhgRqAuYOJzeTr0t8VSptE8fmun+bTU5dmoGdI4m4RkmTn2+EqqMXWSAK9EO+5qJ3Q== X-Received: by 2002:adf:f0c3:: with SMTP id x3mr668795wro.327.1607474911289; Tue, 08 Dec 2020 16:48:31 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id 64sm18206wmd.12.2020.12.08.16.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 16:48:30 -0800 (PST) Date: Wed, 9 Dec 2020 01:48:28 +0100 From: Daniel Vetter To: Tian Tao Subject: Re: [PATCH] drm/tidss: Use the new api devm_drm_irq_install Message-ID: <20201209004828.GN401619@phenom.ffwll.local> Mail-Followup-To: Tian Tao , jsarha@ti.com, tomi.valkeinen@ti.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1607413859-63365-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1607413859-63365-1-git-send-email-tiantao6@hisilicon.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, jsarha@ti.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Dec 08, 2020 at 03:50:59PM +0800, Tian Tao wrote: > Use devm_drm_irq_install to register interrupts so that > drm_irq_uninstall is not needed to be called. > > Signed-off-by: Tian Tao There's another drm_irq_install in the error path. But I'm not sure this is safe since you're chaning the order in which things get cleaned up now. So leaving this up to Tomi. -Daniel > --- > drivers/gpu/drm/tidss/tidss_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c > index 66e3c86e..48e1f9d 100644 > --- a/drivers/gpu/drm/tidss/tidss_drv.c > +++ b/drivers/gpu/drm/tidss/tidss_drv.c > @@ -173,7 +173,7 @@ static int tidss_probe(struct platform_device *pdev) > goto err_runtime_suspend; > } > > - ret = drm_irq_install(ddev, irq); > + ret = devm_irq_install(ddev, irq); > if (ret) { > dev_err(dev, "drm_irq_install failed: %d\n", ret); > goto err_runtime_suspend; > @@ -219,8 +219,6 @@ static int tidss_remove(struct platform_device *pdev) > > drm_atomic_helper_shutdown(ddev); > > - drm_irq_uninstall(ddev); > - > #ifndef CONFIG_PM > /* If we don't have PM, we need to call suspend manually */ > dispc_runtime_suspend(tidss->dispc); > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel