Re: [PATCH 2/3] drm/ttm: move memory accounting into vmwgfx

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3347 bytes --]

Hi "Christian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on next-20210125]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.11-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-ttm-rework-ttm_tt-page-limit-v3/20210126-140030
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-a003-20210126 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 925ae8c790c7e354f12ec14a6cac6aa49fc75b29)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/8bdbdb659aa407a4f3e28dab6d6465304d326888
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christian-K-nig/drm-ttm-rework-ttm_tt-page-limit-v3/20210126-140030
        git checkout 8bdbdb659aa407a4f3e28dab6d6465304d326888
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1515:44: warning: variable 'vmw' is uninitialized when used here [-Wuninitialized]
           ret = ttm_mem_global_init(&ttm_mem_glob, &vmw->drm);
                                                     ^~~
   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1504:25: note: initialize the variable 'vmw' to silence this warning
           struct vmw_private *vmw;
                                  ^
                                   = NULL
   1 warning generated.


vim +/vmw +1515 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

  1501	
  1502	static int vmw_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
  1503	{
  1504		struct vmw_private *vmw;
  1505		int ret;
  1506	
  1507		ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, "svgadrmfb");
  1508		if (ret)
  1509			return ret;
  1510	
  1511		ret = pcim_enable_device(pdev);
  1512		if (ret)
  1513			return ret;
  1514	
> 1515		ret = ttm_mem_global_init(&ttm_mem_glob, &vmw->drm);
  1516		if (ret)
  1517			return ret;
  1518	
  1519		vmw = devm_drm_dev_alloc(&pdev->dev, &driver,
  1520					 struct vmw_private, drm);
  1521		if (IS_ERR(vmw))
  1522			return PTR_ERR(vmw);
  1523	
  1524		pci_set_drvdata(pdev, &vmw->drm);
  1525	
  1526		ret = vmw_driver_load(vmw, ent->device);
  1527		if (ret)
  1528			return ret;
  1529	
  1530		ret = drm_dev_register(&vmw->drm, 0);
  1531		if (ret) {
  1532			vmw_driver_unload(&vmw->drm);
  1533			return ret;
  1534		}
  1535	
  1536		return 0;
  1537	}
  1538	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41828 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel