From: Dan Carpenter <dan.carpenter@oracle.com>
To: Adrien Grassein <adrien.grassein@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 1/1] drm/bridge: lt8912b: Fix issues found during static analysis
Date: Wed, 31 Mar 2021 14:35:54 +0300 [thread overview]
Message-ID: <20210331113554.GM2088@kadam> (raw)
In-Reply-To: <20210331112137.368641-2-adrien.grassein@gmail.com>
On Wed, Mar 31, 2021 at 01:21:37PM +0200, Adrien Grassein wrote:
> - lt->data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> + data_lanes = of_property_count_u32_elems(endpoint, "data-lanes");
> of_node_put(endpoint);
> + if (data_lanes < 0) {
> + dev_err(lt->dev, "%s: Bad data-lanes property\n", __func__);
> + return lt->data_lanes;
This needs to be "return data_lanes;"
> + }
> + lt->data_lanes = data_lanes;
I really believe that v4 will be the perfect version though... :)
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-31 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 11:21 [PATCH v3 0/1] Fixes 30e2ae943c26 "drm/bridge: Introduce LT8912B DSI to HDMI" Adrien Grassein
2021-03-31 11:21 ` [PATCH v3 1/1] drm/bridge: lt8912b: Fix issues found during static analysis Adrien Grassein
2021-03-31 11:35 ` Dan Carpenter [this message]
2021-03-31 11:48 ` Adrien Grassein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331113554.GM2088@kadam \
--to=dan.carpenter@oracle.com \
--cc=adrien.grassein@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox