Re: [PATCH 2/4] drm/amd/display: Add FPU event trace

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3180 bytes --]

Hi Rodrigo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20210331]
[cannot apply to linus/master v5.12-rc5 v5.12-rc4 v5.12-rc3 v5.12-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rodrigo-Siqueira/drm-amd-display-Base-changes-for-isolating-FPU-operation-in-a-single-place/20210331-202750
base:    7a43c78d0573e0bbbb0456b033e2b9a895b89464
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/5859110d0579f7ee57ca1b1840c3960492a9c0c0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Rodrigo-Siqueira/drm-amd-display-Base-changes-for-isolating-FPU-operation-in-a-single-place/20210331-202750
        git checkout 5859110d0579f7ee57ca1b1840c3960492a9c0c0
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:41:6: warning: no previous prototype for 'dc_fpu_begin' [-Wmissing-prototypes]
      41 | void dc_fpu_begin(const char *function_name, const int line)
         |      ^~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:57:6: warning: no previous prototype for 'dc_fpu_end' [-Wmissing-prototypes]
      57 | void dc_fpu_end(const char *function_name, const int line)
         |      ^~~~~~~~~~


vim +/dc_fpu_begin +41 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c

    30	
    31	/**
    32	 * dc_fpu_begin - Enables FPU protection
    33	 * @function_name: A string containing the function name for debug purposes
    34	 * @line: A-line number where DC_FP_START was invoked for debug purpose
    35	 *
    36	 * This function is responsible for managing the use of kernel_fpu_begin() with
    37	 * the advantage of providing an event trace for debugging.
    38	 *
    39	 * Note: Do not call this function directly; always use DC_FP_START().
    40	 */
  > 41	void dc_fpu_begin(const char *function_name, const int line)
    42	{
    43		TRACE_DCN_FPU(true, function_name, line);
    44		kernel_fpu_begin();
    45	}
    46	
    47	/**
    48	 * dc_fpu_end - Disable FPU protection
    49	 * @function_name: A string containing the function name for debug purposes
    50	 * @line: A-line number where DC_FP_END was invoked for debug purpose
    51	 *
    52	 * This function is responsible for managing the use of kernel_fpu_end() with
    53	 * the advantage of providing an event trace for debugging.
    54	 *
    55	 * Note: Do not call this function directly; always use DC_FP_END().
    56	 */
  > 57	void dc_fpu_end(const char *function_name, const int line)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65866 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel