dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: dri-devel@lists.freedesktop.org, Daniel Stone <daniels@collabora.com>
Subject: Re: [PATCH 2/3] drm: clarify and linkify DRM_CLIENT_CAP_WRITEBACK_CONNECTORS docs
Date: Thu, 20 May 2021 11:17:43 +0300	[thread overview]
Message-ID: <20210520111743.62abdcbc@eldfell> (raw)
In-Reply-To: <J47jNf2tAKjofhxL2LEdu1b3w1iRaisxtLCVObf9A@cp4-web-037.plabs.ch>

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

On Tue, 18 May 2021 11:14:47 +0000
Simon Ser <contact@emersion.fr> wrote:

> Make it clear that the client is responsible for enabling ATOMIC
> prior to enabling WRITEBACK_CONNECTORS. Linkify the reference to
> ATOMIC.
> 
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Daniel Stone <daniels@collabora.com>
> Cc: Pekka Paalanen <ppaalanen@gmail.com>
> ---
>  include/uapi/drm/drm.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> index 1c947227f72b..87878aea4526 100644
> --- a/include/uapi/drm/drm.h
> +++ b/include/uapi/drm/drm.h
> @@ -812,8 +812,8 @@ struct drm_get_cap {
>   * DRM_CLIENT_CAP_WRITEBACK_CONNECTORS
>   *
>   * If set to 1, the DRM core will expose special connectors to be used for
> - * writing back to memory the scene setup in the commit. Depends on client
> - * also supporting DRM_CLIENT_CAP_ATOMIC
> + * writing back to memory the scene setup in the commit. The client must enable
> + * &DRM_CLIENT_CAP_ATOMIC first.
>   */
>  #define DRM_CLIENT_CAP_WRITEBACK_CONNECTORS	5
>  

I'll take your word that this is how it must be done.

Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>


Thanks,
pq

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-05-20  8:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 11:14 [PATCH 2/3] drm: clarify and linkify DRM_CLIENT_CAP_WRITEBACK_CONNECTORS docs Simon Ser
2021-05-20  8:17 ` Pekka Paalanen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210520111743.62abdcbc@eldfell \
    --to=ppaalanen@gmail.com \
    --cc=contact@emersion.fr \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox