From: Pekka Paalanen <ppaalanen@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: dri-devel@lists.freedesktop.org, Daniel Stone <daniels@collabora.com>
Subject: Re: [PATCH 1/3] drm: reference mode flags in DRM_CLIENT_CAP_* docs
Date: Thu, 20 May 2021 11:17:50 +0300 [thread overview]
Message-ID: <20210520111750.0950243b@eldfell> (raw)
In-Reply-To: <Yjo91Qsg0kYg3xGZAkEOSYjNm3YGkjElS6wObR59vz0@cp4-web-027.plabs.ch>
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]
On Tue, 18 May 2021 11:14:42 +0000
Simon Ser <contact@emersion.fr> wrote:
> In the docs for DRM_CLIENT_CAP_STEREO_3D and
> DRM_CLIENT_CAP_ASPECT_RATIO, reference the DRM_MODE_FLAG_* defines
> that get set when the cap is enabled.
>
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Daniel Stone <daniels@collabora.com>
> Cc: Pekka Paalanen <ppaalanen@gmail.com>
> ---
> include/uapi/drm/drm.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> index 67b94bc3c885..1c947227f72b 100644
> --- a/include/uapi/drm/drm.h
> +++ b/include/uapi/drm/drm.h
> @@ -777,9 +777,9 @@ struct drm_get_cap {
> /**
> * DRM_CLIENT_CAP_STEREO_3D
> *
> - * if set to 1, the DRM core will expose the stereo 3D capabilities of the
> + * If set to 1, the DRM core will expose the stereo 3D capabilities of the
> * monitor by advertising the supported 3D layouts in the flags of struct
> - * drm_mode_modeinfo.
> + * drm_mode_modeinfo. See ``DRM_MODE_FLAG_3D_*``.
> */
> #define DRM_CLIENT_CAP_STEREO_3D 1
>
> @@ -804,6 +804,7 @@ struct drm_get_cap {
> * DRM_CLIENT_CAP_ASPECT_RATIO
> *
> * If set to 1, the DRM core will provide aspect ratio information in modes.
> + * See ``DRM_MODE_FLAG_PIC_AR_*``.
> */
> #define DRM_CLIENT_CAP_ASPECT_RATIO 4
>
Good.
Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Thanks,
pq
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-05-20 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 11:14 [PATCH 1/3] drm: reference mode flags in DRM_CLIENT_CAP_* docs Simon Ser
2021-05-20 8:17 ` Pekka Paalanen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520111750.0950243b@eldfell \
--to=ppaalanen@gmail.com \
--cc=contact@emersion.fr \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox