From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD80DC47078 for ; Fri, 21 May 2021 14:42:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A303D613E4 for ; Fri, 21 May 2021 14:42:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A303D613E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A9D826E17C; Fri, 21 May 2021 14:42:41 +0000 (UTC) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id B408B6E17C for ; Fri, 21 May 2021 14:42:40 +0000 (UTC) Received: by mail-oi1-x235.google.com with SMTP id u11so19844934oiv.1 for ; Fri, 21 May 2021 07:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5Z2KkwCEfM/BotE4mJLxeXlSEUL4YCagVaLjGTvy9fg=; b=vT57+LogiFiec6wgtvPzqP6wwylRI+H3RY7Yz247iK9wZws/fiqF12NsNQp4BqIbHZ TDsvykaL9rSu62USDGS+LufAkxWR5hZ2ykz2EInJ7msEAyM2gVjcr9qjIN/Cp8j29bpO jR9+fo3hhoUy6JsiZ162qXXS8bw4fZMF0lTzImjiXJtxTKdIrmnWz62BDhUqU4EUkLA6 nz+Ry/eundYbkEnNQp38dxhU17Tk27tiv9Lk1WRlLhNzrqhXwtRywi7nQrgeSjmeL2Tu OuJM5VVMAW9jE4krg+HwJP/K42KgoBH4IylPXbHa1Rm3mXZDljPnh1sw2/sIqbdyWaLY tiqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5Z2KkwCEfM/BotE4mJLxeXlSEUL4YCagVaLjGTvy9fg=; b=ZzTaps7QQ92H7ZBfuUVasYcnJeGmX+wslX81HsFzXdXcprE1IFVhmPC67Wjyt6xsDN wPzuVyIREeGfEFHjCnbqW+XcNQCRoqQimr1qI6eKKm7W0yYtpKnGNPXap3WtzospIWpl QmUn76LExYj7kRrr+J6gzHQN7V/RPb4gOImuL1vQmivqvDq/xU94p65wHqGhlf+C+Jin tGudnlij+ffOOqAzlDDWft+A8w53WUN4cEcppg5Py00F63cMvmdgqRqrjSo6/sisXUHM BWmP+VYb69oILkn9q0KuLwMdYbzMSFqFRqC5drYv2sN1IF1g4C6SUTPIFnVl48fZTIbO 9P2Q== X-Gm-Message-State: AOAM531D4ZnX/wJEkLEwBPvHuyXL6bL1grjVazmV+v1kk3J09MG6IzkR PBBg28EatZhaqqps/oobYiqTMw== X-Google-Smtp-Source: ABdhPJwnIJOU+D/nOQmEzRVwv3lT8IqqVtQca3zuNpPqbOdtvyDqSMrLplRNdstZzXFnadfmsqO24Q== X-Received: by 2002:aca:2417:: with SMTP id n23mr2376892oic.111.1621608159986; Fri, 21 May 2021 07:42:39 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r10sm1164085oic.4.2021.05.21.07.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 07:42:39 -0700 (PDT) Date: Fri, 21 May 2021 09:42:37 -0500 From: Bjorn Andersson To: Vinod Koul Subject: Re: [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters Message-ID: <20210521144237.GZ2484@yoga> References: <20210521124946.3617862-1-vkoul@kernel.org> <20210521124946.3617862-3-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521124946.3617862-3-vkoul@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jonathan Marek , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abhinav Kumar , Rob Herring , dri-devel@lists.freedesktop.org, Dmitry Baryshkov , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri 21 May 07:49 CDT 2021, Vinod Koul wrote: > DSC enables streams to be compressed before we send to panel. This > requires DSC enabled encoder and a panel to be present. So we add this > information in board DTS and find if DSC can be enabled and the > parameters required to configure DSC are added to binding document along > with example > > Signed-off-by: Vinod Koul > --- > .../devicetree/bindings/display/msm/dsi.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt > index b9a64d3ff184..83d2fb92267e 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi.txt > +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt > @@ -48,6 +48,13 @@ Optional properties: > - pinctrl-n: the "sleep" pinctrl state > - ports: contains DSI controller input and output ports as children, each > containing one endpoint subnode. > +- qcom,mdss-dsc-enabled: Display Stream Compression (DSC) is enabled > +- qcom,mdss-slice-height: DSC slice height in pixels > +- qcom,mdss-slice-width: DSC slice width in pixels > +- qcom,mdss-slice-per-pkt: DSC slices per packet > +- qcom,mdss-bit-per-component: DSC bits per component > +- qcom,mdss-bit-per-pixel: DSC bits per pixel > +- qcom,mdss-block-prediction-enable: Block prediction mode of DSC enabled > > DSI Endpoint properties: > - remote-endpoint: For port@0, set to phandle of the connected panel/bridge's > @@ -188,6 +195,14 @@ Example: > qcom,master-dsi; > qcom,sync-dual-dsi; > > + qcom,mdss-dsc-enabled; To me the activation of DSC seems to be a property of the panel. > + qcom,mdss-slice-height = <16>; > + qcom,mdss-slice-width = <540>; > + qcom,mdss-slice-per-pkt = <1>; > + qcom,mdss-bit-per-component = <8>; > + qcom,mdss-bit-per-pixel = <8>; > + qcom,mdss-block-prediction-enable; Which of these properties relates to the DSC encoder and what needs to be agreed with the sink? Can't we derive e.g. bpp from the information we have from the attached panel already? Regards, Bjorn > + > qcom,mdss-mdp-transfer-time-us = <12000>; > > pinctrl-names = "default", "sleep"; > -- > 2.26.3 >