From: Mikko Perttunen <mperttunen@nvidia.com>
To: thierry.reding@gmail.com, jonathanh@nvidia.com, digetx@gmail.com,
airlied@linux.ie, daniel@ffwll.ch
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: [PATCH v6 08/14] drm/tegra: Allocate per-engine channel in core code
Date: Sun, 30 May 2021 15:21:50 +0300 [thread overview]
Message-ID: <20210530122156.3292479-9-mperttunen@nvidia.com> (raw)
In-Reply-To: <20210530122156.3292479-1-mperttunen@nvidia.com>
To avoid code duplication, allocate the per-engine shared channel in
the core code instead. This is the usual channel that all jobs are
submitted to when MLOCKing is not in use. Once MLOCKs are implemented
on Host1x side, we can also update this to avoid allocating a shared
channel when MLOCKs are enabled.
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
---
v6:
- Reorder fields in drm.h to put core-controlled fields first
---
drivers/gpu/drm/tegra/drm.c | 11 +++++++++++
drivers/gpu/drm/tegra/drm.h | 2 ++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index c9a35c1dc970..a27e5a89d676 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -869,6 +869,14 @@ static const struct drm_driver tegra_drm_driver = {
int tegra_drm_register_client(struct tegra_drm *tegra,
struct tegra_drm_client *client)
{
+ /*
+ * When MLOCKs are implemented, change to allocate a shared channel
+ * only when MLOCKs are disabled.
+ */
+ client->shared_channel = host1x_channel_request(&client->base);
+ if (!client->shared_channel)
+ return -EBUSY;
+
mutex_lock(&tegra->clients_lock);
list_add_tail(&client->list, &tegra->clients);
client->drm = tegra;
@@ -885,6 +893,9 @@ int tegra_drm_unregister_client(struct tegra_drm *tegra,
client->drm = NULL;
mutex_unlock(&tegra->clients_lock);
+ if (client->shared_channel)
+ host1x_channel_put(client->shared_channel);
+
return 0;
}
diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h
index f38de08e0c95..1ec07034727c 100644
--- a/drivers/gpu/drm/tegra/drm.h
+++ b/drivers/gpu/drm/tegra/drm.h
@@ -86,7 +86,9 @@ struct tegra_drm_client {
struct host1x_client base;
struct list_head list;
struct tegra_drm *drm;
+ struct host1x_channel *shared_channel;
+ /* Set by driver */
unsigned int version;
const struct tegra_drm_client_ops *ops;
};
--
2.30.1
next prev parent reply other threads:[~2021-05-30 12:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 12:21 [PATCH v6 00/14] TegraDRM UAPI Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 01/14] gpu: host1x: Add DMA fence implementation Mikko Perttunen
2021-05-30 13:45 ` kernel test robot
2021-05-30 12:21 ` [PATCH v6 02/14] gpu: host1x: Add no-recovery mode Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 03/14] gpu: host1x: Add job release callback Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 04/14] gpu: host1x: Add support for syncpoint waits in CDMA pushbuffer Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 05/14] drm/tegra: Extract tegra_gem_lookup Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 06/14] drm/tegra: Add new UAPI to header Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 07/14] drm/tegra: Boot VIC during runtime PM resume Mikko Perttunen
2021-05-30 12:21 ` Mikko Perttunen [this message]
2021-05-30 12:21 ` [PATCH v6 09/14] drm/tegra: Implement new UAPI Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 10/14] drm/tegra: Implement syncpoint management UAPI Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 11/14] drm/tegra: Implement syncpoint wait UAPI Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 12/14] drm/tegra: Implement job submission part of new UAPI Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 13/14] drm/tegra: Add job firewall Mikko Perttunen
2021-05-30 12:21 ` [PATCH v6 14/14] drm/tegra: Bump driver version Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210530122156.3292479-9-mperttunen@nvidia.com \
--to=mperttunen@nvidia.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox