From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Boris Brezillon <bbrezillon@kernel.org>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Dan Sneddon <dan.sneddon@microchip.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm:atmel: Enable the crtc vblank prior to crtc usage.
Date: Sat, 19 Jun 2021 22:28:15 +0200 [thread overview]
Message-ID: <20210619202815.GB533354@ravnborg.org> (raw)
In-Reply-To: <72ac51ca-a7df-c6ce-ba10-5dd26369e137@microchip.com>
Hi Nicolas/Dan,
On Fri, Jun 18, 2021 at 10:05:11AM +0200, Nicolas Ferre wrote:
> Hi Daniel, Sam,
>
> On 02/06/2021 at 18:08, Dan Sneddon wrote:
> > 'commit eec44d44a3d2 ("drm/atmel: Use drm_atomic_helper_commit")'
> > removed the home-grown handling of atomic commits and exposed an issue
> > in the crtc atomic commit handling where vblank is expected to be
> > enabled but hasn't yet, causing kernel warnings during boot. This patch
> > cleans up the crtc vblank handling thus removing the warning on boot.
> >
> > Fixes: eec44d44a3d2 ("drm/atmel: Use drm_atomic_helper_commit")
> >
> > Signed-off-by: Dan Sneddon <dan.sneddon@microchip.com>
>
> Is this fix need more input from us, is there something missing (aka ping)?
Sorry for the loong response time.
I have been off-line for a while. Moved to a new house where some
renovation was needed so it got priority (and still does).
Thanks for the path - patch applied to drm-misc-fixes now.
Sam
prev parent reply other threads:[~2021-06-19 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 16:08 [PATCH] drm:atmel: Enable the crtc vblank prior to crtc usage Dan Sneddon
2021-06-18 8:05 ` Nicolas Ferre
2021-06-19 20:28 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210619202815.GB533354@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=dan.sneddon@microchip.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox