From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFEAC4743C for ; Mon, 21 Jun 2021 14:49:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B91E960C41 for ; Mon, 21 Jun 2021 14:49:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B91E960C41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2378A6E198; Mon, 21 Jun 2021 14:49:52 +0000 (UTC) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by gabe.freedesktop.org (Postfix) with ESMTPS id D54EB6E197 for ; Mon, 21 Jun 2021 14:49:50 +0000 (UTC) Received: by mail-qt1-x835.google.com with SMTP id l2so10814814qtq.10 for ; Mon, 21 Jun 2021 07:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7EhCVDJi9/mtNith6sHIuVtzdsDVwMIUM7u21aSrhMw=; b=pMj9icezCyVPhAoUcyIC4hXg8iF9vNR6ki/LwTLTUx9T50dBy/aY+JIQc2BM9Hz1/z JkL9Jm7F3sTwTj1cBu4VqQ0lfWp+QeZb+UHm3PoPx1trXAkMT1LHeTAZ6a272Hh7Cypf IolYhYiuvw6yY/3OnYlCLxHAyGeUoFVQKeTwptIxn6w6eA5jjABocMAs4na9+zV2VW5T rz9L38LXMzbPG5+9/L86DpSMJOUqS31ppQLS8vlTPUn6gfpb9oKUdfcwayMnbRDQquI9 O2qE291+F/7jfBsLM1X67J41Z4Pn6F3VqTRzoFIhrsTP3dOflNs6XlBQ7VQiN7wGxWNO b1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7EhCVDJi9/mtNith6sHIuVtzdsDVwMIUM7u21aSrhMw=; b=JWzmMMQxPMP+X1T6A1lpMGciotiVLLLE666xs0b0w6W/wJNkDHAvIIRe/GYT5sEWTX MRIXq/SAmk1gq/sLgC7QvQB99X/MfbypK+zbH4ZWs/2Ai3VZ+mvcwcKQYQ+hVS9OGe78 +vkh3EJPoOvhqUht5QNVR7NmzTNNae2t8Z7iLBVAHmWsCoDG9cBD2uFQE4Vg9oSgM7Fs A4HDiVLiLHGsTOTlcMoZJMPKgQ+QMRrewa+dMXpNjtqvMGFX4u4NjcJtquuCPrHM21oa 8AP/vFJsMIov3W1AIjCYUN/r7oK8QYU+4D8sHYxFUpFwsrq6U56eYzuomUMLO9/ErVm2 YDIA== X-Gm-Message-State: AOAM531YvjSBbq4vJw7Rl6ccTCG5C+y9WBjyy361srj1ihgg7Wm0j9ju 0gtwXGeJBe6QtSGW3zKjeJPXcg== X-Google-Smtp-Source: ABdhPJyQ783oDw7ztSH9iUqFrEniMfq/XeByphnoK7SGzg/3oOO5hx+wfM7vN3NxmC0psXJAIBTnIQ== X-Received: by 2002:ac8:4d84:: with SMTP id a4mr24377635qtw.319.1624286989919; Mon, 21 Jun 2021 07:49:49 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-113-94.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.113.94]) by smtp.gmail.com with ESMTPSA id 186sm4426217qkf.29.2021.06.21.07.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 07:49:49 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lvLFE-009XIx-Pt; Mon, 21 Jun 2021 11:49:48 -0300 Date: Mon, 21 Jun 2021 11:49:48 -0300 From: Jason Gunthorpe To: Greg KH , Oded Gabbay , linux-rdma , "open list:DMA BUFFER SHARING FRAMEWORK" , Doug Ledford , "airlied@gmail.com" , Linux Kernel Mailing List , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Gal Pressman , sleybo@amazon.com, dri-devel , Tomer Tayar , "moderated list:DMA BUFFER SHARING FRAMEWORK" , amd-gfx list , Alex Deucher , Leon Romanovsky , Christoph Hellwig Subject: Re: [PATCH v3 1/2] habanalabs: define uAPI to export FD for DMA-BUF Message-ID: <20210621144948.GG1096940@ziepe.ca> References: <20210618123615.11456-1-ogabbay@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jun 21, 2021 at 04:20:35PM +0200, Daniel Vetter wrote: > Also unless we're actually doing this properly there's zero incentive for > me to review the kernel code and check whether it follows the rules > correctly, so you have excellent chances that you just break the rules. > And dma_buf/fence are tricky enough that you pretty much guaranteed to > break the rules if you're not involved in the discussions. Just now we > have a big one where everyone involved (who's been doing this for 10+ > years all at least) realizes we've fucked up big time. This is where I come from on dmabuf, it is fiendishly complicated. Don't use it unless you absoultely have to, are in DRM, and have people like Daniel helping to make sure you use it right. It's whole premise and design is compromised by specialty historical implementation choices on the GPU side. Jason