Re: [PATCH 2/5] drm/gem: Provide drm_gem_fb_{vmap,vunmap}()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3670 bytes --]

Hi Thomas,

I love your patch! Yet something to improve:

[auto build test ERROR on 4d00e2309398147acdbfefbe1deb4b0e78868466]

url:    https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Provide-framebuffer-vmap-helpers/20210716-020508
base:   4d00e2309398147acdbfefbe1deb4b0e78868466
config: nios2-randconfig-s032-20210715 (attached as .config)
compiler: nios2-linux-gcc (GCC) 10.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/8a0708f4cf232e7fbc4eb6f58cf782200be8912e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Thomas-Zimmermann/drm-Provide-framebuffer-vmap-helpers/20210716-020508
        git checkout 8a0708f4cf232e7fbc4eb6f58cf782200be8912e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/gpu/drm/arm/display/komeda/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c:11:
>> include/drm/drm_gem_framebuffer_helper.h:39:72: error: 'DRM_FORMAT_MAX_PLANES' undeclared here (not in a function)
      39 | int drm_gem_fb_vmap(struct drm_framebuffer *fb, struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]);
         |                                                                        ^~~~~~~~~~~~~~~~~~~~~
   include/drm/drm_gem_framebuffer_helper.h:40:75: error: 'DRM_FORMAT_MAX_PLANES' undeclared here (not in a function)
      40 | void drm_gem_fb_vunmap(struct drm_framebuffer *fb, struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]);
         |                                                                           ^~~~~~~~~~~~~~~~~~~~~


vim +/DRM_FORMAT_MAX_PLANES +39 include/drm/drm_gem_framebuffer_helper.h

    16	
    17	struct drm_gem_object *drm_gem_fb_get_obj(struct drm_framebuffer *fb,
    18						  unsigned int plane);
    19	void drm_gem_fb_destroy(struct drm_framebuffer *fb);
    20	int drm_gem_fb_create_handle(struct drm_framebuffer *fb, struct drm_file *file,
    21				     unsigned int *handle);
    22	
    23	int drm_gem_fb_init_with_funcs(struct drm_device *dev,
    24				       struct drm_framebuffer *fb,
    25				       struct drm_file *file,
    26				       const struct drm_mode_fb_cmd2 *mode_cmd,
    27				       const struct drm_framebuffer_funcs *funcs);
    28	struct drm_framebuffer *
    29	drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file,
    30				     const struct drm_mode_fb_cmd2 *mode_cmd,
    31				     const struct drm_framebuffer_funcs *funcs);
    32	struct drm_framebuffer *
    33	drm_gem_fb_create(struct drm_device *dev, struct drm_file *file,
    34			  const struct drm_mode_fb_cmd2 *mode_cmd);
    35	struct drm_framebuffer *
    36	drm_gem_fb_create_with_dirty(struct drm_device *dev, struct drm_file *file,
    37				     const struct drm_mode_fb_cmd2 *mode_cmd);
    38	
  > 39	int drm_gem_fb_vmap(struct drm_framebuffer *fb, struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]);
    40	void drm_gem_fb_vunmap(struct drm_framebuffer *fb, struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]);
    41	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30515 bytes --]