dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm: add logging for RMFB ioctl
Date: Tue, 27 Jul 2021 11:03:12 +0300	[thread overview]
Message-ID: <20210727110312.7902260c@eldfell> (raw)
In-Reply-To: <YP8VRU+NDsS276gU@ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

On Mon, 26 Jul 2021 22:04:21 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:

> Hi Simon,
> 
> On Mon, Jul 26, 2021 at 07:49:06AM +0000, Simon Ser wrote:
> > We already have logging for ADDFB2. Add some logging for RMFB as
> > well.
> > 
> > This can be handy when trying to find out why a CRTC gets magically
> > disabled.
> > 
> > v2: make log message more explicit, add log messages to
> > drm_framebuffer_remove (Daniel)
> > 
> > Signed-off-by: Simon Ser <contact@emersion.fr>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>  
> 
> Looks like some very useful debugging logging.
> 
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Yes indeed!

Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>


Thanks,
pq

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-07-27  8:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26  7:49 [PATCH v2] drm: add logging for RMFB ioctl Simon Ser
2021-07-26 20:04 ` Sam Ravnborg
2021-07-27  8:03   ` Pekka Paalanen [this message]
2021-07-27  9:39 ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210727110312.7902260c@eldfell \
    --to=ppaalanen@gmail.com \
    --cc=contact@emersion.fr \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox