From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCDCC4338F for ; Tue, 17 Aug 2021 16:04:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B48860FD7 for ; Tue, 17 Aug 2021 16:04:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B48860FD7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stuge.se Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 582D06E1F6; Tue, 17 Aug 2021 16:04:16 +0000 (UTC) Received: from foo.stuge.se (foo.stuge.se [212.116.89.98]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DE7B6E283 for ; Tue, 17 Aug 2021 16:03:11 +0000 (UTC) Received: (qmail 21027 invoked by uid 1000); 17 Aug 2021 16:03:07 -0000 Message-ID: <20210817160307.21026.qmail@stuge.se> Date: Tue, 17 Aug 2021 16:03:07 +0000 From: Peter Stuge To: Daniel Vetter Cc: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org, linus.walleij@linaro.org, Thomas Zimmermann Subject: Re: [PATCH 2/7] drm/format-helper: Add drm_fb_xrgb8888_to_rgb332() References: <20210817122917.49929-1-noralf@tronnes.org> <20210817122917.49929-3-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Daniel Vetter wrote: > Also I just realized we've totally ignored endianess on these, which is > not great, because strictly speaking all the drm_fourcc codes should be > little endian. But I'm also not sure that's worth fixing ... We discussed framebuffer endianess when introducing the driver, in the thread linked near the FIXME comment in the code. I proposed an untested fix but Noralf wanted to wait for testing, which I find fair. I don't think anyone has tested on BE yet. It's on my nice-to-have list, but not at the top, and has blockers, so if anyone else can test on BE please do. I'd recommend testing with an actual device to compare LE and BE behavior easily. Kind regards //Peter