From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C8AC433EF for ; Mon, 27 Sep 2021 09:42:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B5EC6115C for ; Mon, 27 Sep 2021 09:42:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B5EC6115C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A64E56E838; Mon, 27 Sep 2021 09:42:05 +0000 (UTC) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id A846A6E838 for ; Mon, 27 Sep 2021 09:42:04 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id c21so20961347wrb.13 for ; Mon, 27 Sep 2021 02:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AOd3DSSJEh7FjHG/mu9DSVCacQHAVqSPOn9FFZX+TDo=; b=bJ/6URt8mZ58hZVR1HRraD8UFutUqCyIH+v76AnMaiuYUB2S78EKqrFdru+Y0ocBuK LZWNMwcSxP0OV5mTMvO7iKSIJNxtUw9m9HX9XFp4v/pBjazDAMHgnTKfkxaPE0/XVY6k s2S8cIKDq+q1vF1tN90Yb+wVZS5qt/4+vqceeqP55zewqx2SP/JxHD0DMQxmeEJGbR4v 8I6BY2zWSrFxWFalk8GiZddb0PM5futGtBOBMxVND+EQZnYvG9IXYfI4dlOjtJZa7d6q TPnt8KHEDorwbB2g3MvMxUfLhm/KFi5SmBrpthYt9lwo9FTS1a1yyesI99YeDT//PzJj oCAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AOd3DSSJEh7FjHG/mu9DSVCacQHAVqSPOn9FFZX+TDo=; b=b0KkZ9UzxXXDHL6CBB2NZhTs3+sA4J7FAXRrjnOtPLc8vFhXYaLSIT9OE+Oy7kENho bi0Y0yaD4WfM5bRiJBCHO379p/W0AlQXB2RNwtdgJCBLlhp81IA3aWcAdhIytryNUabH l2DQ07W/SoZFoW04jSRdEZZZNWsRYmtPI/Pz50UoMwpXDBJDBEJWIjm8mGRU8LVqOqC/ pu0v56PXyyIURDtJYHfJGC/P6AoSsGVRV1y6wKW3bvKpRRN9NrkOscwWWzzJh7FiY9QY Uw/jkRux/2DdJ74SccFJrM4VhDpfjfCyy4MCOcn73i8YlTERYKHCediEUjlqT9oWYnDl ZcGA== X-Gm-Message-State: AOAM532gv7UTgv4yyHw/x9aao51kxpyhDlJSGKiyjof5pCTjiwwG6ETZ AOorskxU69Unbfva+OSMHFvFBg== X-Google-Smtp-Source: ABdhPJwuBfuf1mGVJGpqb6JLQPeqaPjF7TGxssF9xcq1RpummfDkKDco8qTM4I+v2BUXVl9U/SqDJw== X-Received: by 2002:adf:f94b:: with SMTP id q11mr16116559wrr.408.1632735723038; Mon, 27 Sep 2021 02:42:03 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id z79sm16927330wmc.17.2021.09.27.02.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 02:42:02 -0700 (PDT) Date: Mon, 27 Sep 2021 10:42:00 +0100 From: Daniel Thompson To: Mark Brown Cc: Lee Jones , Jingoo Han , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH] backlight: hx8357: Add SPI device ID table Message-ID: <20210927094200.a7d73sl2k4x5xjch@maple.lan> References: <20210922151014.49719-1-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210922151014.49719-1-broonie@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 22, 2021 at 04:10:14PM +0100, Mark Brown wrote: > Currently autoloading for SPI devices does not use the DT ID table, it uses > SPI modalises. Supporting OF modalises is going to be difficult if not > impractical, an attempt was made but has been reverted, so ensure that > module autoloading works for this driver by adding a SPI device ID table. > > Fixes: 96c8395e2166 ("spi: Revert modalias changes") > Signed-off-by: Mark Brown > --- > drivers/video/backlight/hx8357.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/backlight/hx8357.c > index 9b50bc96e00f..c64b1fbe027f 100644 > --- a/drivers/video/backlight/hx8357.c > +++ b/drivers/video/backlight/hx8357.c > @@ -565,6 +565,19 @@ static struct lcd_ops hx8357_ops = { > .get_power = hx8357_get_power, > }; > > +static const struct spi_device_id hx8357_spi_ids[] = { > + { > + .name = "hx8357", > + .driver_data = (kernel_ulong_t)hx8357_lcd_init, Based on this I had expected to find spi_get_device_id() and a ->driver_data somewhere in this patch. Where will this .driver_data be consumed? Daniel. > + }, > + { > + .name = "hx8369", > + .driver_data = (kernel_ulong_t)hx8369_lcd_init, > + }, > + {}, > +}; > +MODULE_DEVICE_TABLE(spi, hx8357_spi_ids); > + > static const struct of_device_id hx8357_dt_ids[] = { > { > .compatible = "himax,hx8357", > @@ -672,6 +685,7 @@ static struct spi_driver hx8357_driver = { > .name = "hx8357", > .of_match_table = hx8357_dt_ids, > }, > + .id_table = hx8357_spi_ids, > }; > > module_spi_driver(hx8357_driver); > -- > 2.20.1 >