dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
To: dri-devel@lists.freedesktop.org, anitha.chrisanthus@intel.com
Cc: sam@ravnborg.org, edmund.j.dea@intel.com
Subject: [PATCH v3 3/7] drm/kmb: Remove clearing DPHY regs
Date: Wed, 13 Oct 2021 16:36:28 -0700	[thread overview]
Message-ID: <20211013233632.471892-3-anitha.chrisanthus@intel.com> (raw)
In-Reply-To: <20211013233632.471892-1-anitha.chrisanthus@intel.com>

From: Edmund Dea <edmund.j.dea@intel.com>

Don't clear the shared DPHY registers common to MIPI Rx and MIPI Tx during
DSI initialization since this was causing MIPI Rx reset. Rest of the
writes are bitwise, so will not affect Mipi Rx side.

Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver")
Signed-off-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
Signed-off-by: Edmund Dea <edmund.j.dea@intel.com>
---
 drivers/gpu/drm/kmb/kmb_dsi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c
index 86e8e7943e89..a0669b842ff5 100644
--- a/drivers/gpu/drm/kmb/kmb_dsi.c
+++ b/drivers/gpu/drm/kmb/kmb_dsi.c
@@ -1393,11 +1393,6 @@ int kmb_dsi_mode_set(struct kmb_dsi *kmb_dsi, struct drm_display_mode *mode,
 		mipi_tx_init_cfg.lane_rate_mbps = data_rate;
 	}
 
-	kmb_write_mipi(kmb_dsi, DPHY_ENABLE, 0);
-	kmb_write_mipi(kmb_dsi, DPHY_INIT_CTRL0, 0);
-	kmb_write_mipi(kmb_dsi, DPHY_INIT_CTRL1, 0);
-	kmb_write_mipi(kmb_dsi, DPHY_INIT_CTRL2, 0);
-
 	/* Initialize mipi controller */
 	mipi_tx_init_cntrl(kmb_dsi, &mipi_tx_init_cfg);
 
-- 
2.25.1


  parent reply	other threads:[~2021-10-13 23:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 23:36 [PATCH v3 1/7] drm/kmb: Work around for higher system clock Anitha Chrisanthus
2021-10-13 23:36 ` [PATCH v3 2/7] drm/kmb: Limit supported mode to 1080p Anitha Chrisanthus
2021-10-14 18:36   ` Sam Ravnborg
2021-10-13 23:36 ` Anitha Chrisanthus [this message]
2021-10-14 18:37   ` [PATCH v3 3/7] drm/kmb: Remove clearing DPHY regs Sam Ravnborg
2021-10-13 23:36 ` [PATCH v3 4/7] drm/kmb: Disable change of plane parameters Anitha Chrisanthus
2021-10-14 18:39   ` Sam Ravnborg
2021-10-13 23:36 ` [PATCH v3 5/7] drm/kmb: Corrected typo in handle_lcd_irq Anitha Chrisanthus
2021-10-14 18:40   ` Sam Ravnborg
2021-10-13 23:36 ` [PATCH v3 6/7] drm/kmb: Enable ADV bridge after modeset Anitha Chrisanthus
2021-10-14 18:44   ` Sam Ravnborg
2021-10-13 23:36 ` [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console Anitha Chrisanthus
2021-10-14 12:50   ` Thomas Zimmermann
2021-10-15 17:17     ` Chrisanthus, Anitha
2021-10-14 13:08   ` Thomas Zimmermann
2021-10-15 17:16     ` Chrisanthus, Anitha
2021-10-14 18:33 ` [PATCH v3 1/7] drm/kmb: Work around for higher system clock Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211013233632.471892-3-anitha.chrisanthus@intel.com \
    --to=anitha.chrisanthus@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=edmund.j.dea@intel.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox