From: Simon Ser <contact@emersion.fr>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event
Date: Fri, 15 Oct 2021 16:33:45 +0000 [thread overview]
Message-ID: <20211015163336.95188-6-contact@emersion.fr> (raw)
In-Reply-To: <20211015163336.95188-1-contact@emersion.fr>
If an hotplug event only updates a single connector, use
drm_kms_helper_connector_hotplug_event instead of
drm_kms_helper_hotplug_event.
Signed-off-by: Simon Ser <contact@emersion.fr>
---
drivers/gpu/drm/drm_probe_helper.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 3aef3b188c99..6049dc92324b 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -927,7 +927,7 @@ EXPORT_SYMBOL(drm_connector_helper_hpd_irq_event);
*/
bool drm_helper_hpd_irq_event(struct drm_device *dev)
{
- struct drm_connector *connector;
+ struct drm_connector *connector, *changed_connector = NULL;
struct drm_connector_list_iter conn_iter;
bool changed = false;
@@ -941,15 +941,27 @@ bool drm_helper_hpd_irq_event(struct drm_device *dev)
if (!(connector->polled & DRM_CONNECTOR_POLL_HPD))
continue;
- if (check_connector_changed(connector))
+ if (check_connector_changed(connector)) {
+ if (changed) {
+ if (changed_connector)
+ drm_connector_put(changed_connector);
+ changed_connector = NULL;
+ } else {
+ drm_connector_get(connector);
+ changed_connector = connector;
+ }
+
changed = true;
+ }
}
drm_connector_list_iter_end(&conn_iter);
mutex_unlock(&dev->mode_config.mutex);
- if (changed) {
+ if (changed_connector) {
+ drm_kms_helper_connector_hotplug_event(changed_connector);
+ drm_connector_put(changed_connector);
+ } else if (changed) {
drm_kms_helper_hotplug_event(dev);
- DRM_DEBUG_KMS("Sent hotplug event\n");
}
return changed;
--
2.33.1
next prev parent reply other threads:[~2021-10-15 16:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 16:33 [PATCH v3 0/6] drm: add per-connector hotplug events Simon Ser
2021-10-15 16:33 ` [PATCH v3 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event Simon Ser
2021-10-15 19:37 ` Sam Ravnborg
2021-10-15 19:42 ` Sam Ravnborg
2021-10-15 16:33 ` [PATCH v3 2/6] drm/probe-helper: add drm_kms_helper_connector_hotplug_event Simon Ser
2021-10-15 19:43 ` Sam Ravnborg
2021-10-15 16:33 ` [PATCH v3 3/6] drm/connector: use drm_sysfs_connector_hotplug_event Simon Ser
2021-10-15 19:44 ` Sam Ravnborg
2021-10-27 13:15 ` Pekka Paalanen
2021-10-27 13:26 ` Simon Ser
2021-10-28 7:32 ` Pekka Paalanen
2021-10-15 16:33 ` [PATCH v3 4/6] amdgpu: use drm_kms_helper_connector_hotplug_event Simon Ser
2021-10-15 19:26 ` Harry Wentland
2021-10-15 16:33 ` Simon Ser [this message]
2021-10-15 19:41 ` [PATCH v3 5/6] drm/probe-helper: " Ville Syrjälä
2021-10-18 8:43 ` Simon Ser
2021-10-15 20:03 ` Sam Ravnborg
2021-10-18 8:45 ` Simon Ser
2021-10-18 8:15 ` Maxime Ripard
2021-10-18 8:44 ` Simon Ser
2021-10-15 16:33 ` [PATCH v3 6/6] i915/display/dp: send a more fine-grained link-status uevent Simon Ser
2021-10-15 19:44 ` Ville Syrjälä
2021-10-18 8:42 ` Simon Ser
2021-10-16 14:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015163336.95188-6-contact@emersion.fr \
--to=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox