From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52861C433F5 for ; Mon, 18 Oct 2021 12:04:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1317961038 for ; Mon, 18 Oct 2021 12:04:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1317961038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52E4A6E9F1; Mon, 18 Oct 2021 12:04:03 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 892F16E9F1 for ; Mon, 18 Oct 2021 12:04:01 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9B0251F42D1C; Mon, 18 Oct 2021 13:03:59 +0100 (BST) Date: Mon, 18 Oct 2021 14:03:56 +0200 From: Boris Brezillon To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, Rob Herring , Tomeu Vizoso , Alyssa Rosenzweig , Steven Price , Robin Murphy , Will Deacon , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/5] [RFC]iommu: Add a IOMMU_DEVONLY protection flag Message-ID: <20211018140356.67a78d1a@collabora.com> In-Reply-To: References: <20211001143427.1564786-1-boris.brezillon@collabora.com> <20211001143427.1564786-2-boris.brezillon@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Joerg, On Mon, 18 Oct 2021 12:25:38 +0200 Joerg Roedel wrote: > On Fri, Oct 01, 2021 at 04:34:23PM +0200, Boris Brezillon wrote: > > +/* > > + * Mapping is only accessed by the device behind the iommu. That means other > > + * devices or CPUs are not expected to access this physical memory region, > > + * and the MMU driver can safely restrict the shareability domain to the > > + * device itself. > > + */ > > +#define IOMMU_DEVONLY (1 << 6) > > I am not entirely happy with the name, how about > > IOMMU_DEV_PRIVATE? Works for me. > > PRIV would conflict with IOMMU_PRIV (which should probably also be > IOMMU_PRIVILEGED, but thats another problem). Yeah, IOMMU_PRIV is confusing. I thought I could use that flag before realizing PRIV was for privileged not private, but I'll leave that to someone else :-). Regards, Boris