From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Mukunda Pramodh Kumar <mukunda.pramodh.kumar@intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
Uma Shankar <uma.shankar@intel.com>,
Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Subject: [i-g-t 13/14] tests/kms_color: Extended IGT tests to support logarithmic gamma mode
Date: Mon, 15 Nov 2021 15:17:58 +0530 [thread overview]
Message-ID: <20211115094759.520955-14-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20211115094759.520955-1-bhanuprakash.modem@intel.com>
From: Mukunda Pramodh Kumar <mukunda.pramodh.kumar@intel.com>
Extended IGT tests to support logarithmic gamma mode on pipe
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Mukunda Pramodh Kumar <mukunda.pramodh.kumar@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_color.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index d9fe417ba9..00742afaaf 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -232,8 +232,6 @@ static void test_pipe_gamma(data_t *data,
igt_require(igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_GAMMA_LUT));
- gamma_full = generate_table_max(data->gamma_lut_size);
-
output = igt_get_single_output_for_pipe(&data->display, primary->pipe->pipe);
igt_require(output);
@@ -258,10 +256,13 @@ static void test_pipe_gamma(data_t *data,
igt_assert(fb_modeset_id);
igt_plane_set_fb(primary, &fb_modeset);
+ /* Reset Color properties */
disable_ctm(primary->pipe);
disable_degamma(primary->pipe);
- set_gamma(data, primary->pipe, gamma_full);
+ disable_gamma(primary->pipe);
igt_display_commit(&data->display);
+ igt_wait_for_vblank(data->drm_fd,
+ display->pipes[primary->pipe->pipe].crtc_offset);
/* Draw solid colors with no gamma transformation. */
paint_rectangles(data, mode, red_green_blue, &fb);
@@ -274,6 +275,13 @@ static void test_pipe_gamma(data_t *data,
/* Draw a gradient with gamma LUT to remap all values
* to max red/green/blue.
*/
+ if (igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_GAMMA_MODE)) {
+ set_advance_gamma(data, primary->pipe, MAX_GAMMA);
+ } else {
+ gamma_full = generate_table_max(data->gamma_lut_size);
+ set_gamma(data, primary->pipe, gamma_full);
+ igt_display_commit(&data->display);
+ }
paint_gradient_rectangles(data, mode, red_green_blue, &fb);
igt_plane_set_fb(primary, &fb);
igt_display_commit(&data->display);
@@ -581,7 +589,10 @@ static bool test_pipe_ctm(data_t *data,
*/
if (memcmp(before, after, sizeof(color_t))) {
set_degamma(data, primary->pipe, degamma_linear);
- set_gamma(data, primary->pipe, gamma_linear);
+ if (igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_GAMMA_MODE))
+ disable_gamma(primary->pipe);
+ else
+ set_gamma(data, primary->pipe, gamma_linear);
} else {
/* Disable Degamma and Gamma for ctm max test */
disable_degamma(primary->pipe);
--
2.32.0
next prev parent reply other threads:[~2021-11-15 9:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 9:47 [i-g-t 00/14] Add IGT support for plane color management Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 01/14] HAX: Get uapi headers to compile the IGT Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 02/14] lib/igt_kms: Add plane color mgmt properties Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 03/14] kms_color_helper: Add helper functions for plane color mgmt Bhanuprakash Modem
2021-11-18 8:41 ` Pekka Paalanen
2022-01-03 4:02 ` Modem, Bhanuprakash
2021-11-26 16:54 ` Harry Wentland
2022-01-03 4:02 ` Modem, Bhanuprakash
2021-11-15 9:47 ` [i-g-t 04/14] tests/kms_color: New subtests for Plane gamma Bhanuprakash Modem
2021-11-18 9:02 ` Pekka Paalanen
2022-01-03 4:09 ` Modem, Bhanuprakash
2021-11-26 16:55 ` Harry Wentland
2022-01-03 4:05 ` Modem, Bhanuprakash
2022-01-04 21:19 ` Harry Wentland
2022-01-05 11:21 ` Modem, Bhanuprakash
2022-01-05 22:13 ` Harry Wentland
2021-11-15 9:47 ` [i-g-t 05/14] tests/kms_color: New subtests for Plane degamma Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 06/14] tests/kms_color: New subtests for Plane CTM Bhanuprakash Modem
2021-11-26 16:55 ` Harry Wentland
2021-11-15 9:47 ` [i-g-t 07/14] tests/kms_color: New negative tests for plane level color mgmt Bhanuprakash Modem
2021-11-18 9:19 ` Pekka Paalanen
2021-11-29 14:56 ` [igt-dev] " Harry Wentland
2022-01-03 4:05 ` Modem, Bhanuprakash
2021-11-15 9:47 ` [i-g-t 08/14] tests/kms_color_chamelium: New subtests for Plane gamma Bhanuprakash Modem
2021-11-18 9:32 ` Pekka Paalanen
2022-01-03 4:06 ` Modem, Bhanuprakash
2021-11-15 9:47 ` [i-g-t 09/14] tests/kms_color_chamelium: New subtests for Plane degamma Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 10/14] tests/kms_color_chamelium: New subtests for Plane CTM Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 11/14] lib/igt_kms: Add pipe color mgmt properties Bhanuprakash Modem
2021-11-18 9:34 ` Pekka Paalanen
2021-11-15 9:47 ` [i-g-t 12/14] kms_color_helper: Add helper functions to support logarithmic gamma mode Bhanuprakash Modem
2021-11-18 9:45 ` Pekka Paalanen
2022-01-03 4:07 ` Modem, Bhanuprakash
2021-11-26 16:55 ` Harry Wentland
2022-01-03 4:08 ` Modem, Bhanuprakash
2021-11-15 9:47 ` Bhanuprakash Modem [this message]
2021-11-15 9:47 ` [i-g-t 14/14] tests/kms_color_chamelium: Extended IGT tests " Bhanuprakash Modem
2021-11-18 9:50 ` [i-g-t 00/14] Add IGT support for plane color management Pekka Paalanen
2021-11-26 16:54 ` Harry Wentland
2021-11-29 9:20 ` Pekka Paalanen
2021-11-29 15:20 ` Harry Wentland
2022-01-03 4:11 ` Modem, Bhanuprakash
2022-01-04 22:01 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115094759.520955-14-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=mukunda.pramodh.kumar@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox