From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A2F5C433FE for ; Fri, 28 Jan 2022 12:45:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A7D8710EC5A; Fri, 28 Jan 2022 12:45:54 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id E912510EC59 for ; Fri, 28 Jan 2022 12:45:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 95B1DB8258F; Fri, 28 Jan 2022 12:45:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1C11C340E0; Fri, 28 Jan 2022 12:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643373950; bh=vMCWcrlcdbFbw6ZhRTSMH5G249xb37QrpyMQTC2Ih8s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OApe1TM9xyUHQMFD6k9FG6o9kh88o2dbdqSEGbm5wq5/qqM5JnhJFTZNaAG/OoevL B51+tarWCZpS/wrJc4n3EK/qeZAo3/0q9InRVDCRcQ46ZibrXrySDoUS0iX5VAZGJZ 2SsMMvYDp37uKklaalMXs5QbfHBQfyTMoGG8HKvXokzoAcJsvCgN5Z1HLStrtn247A 5HaAnpPSZTEmO5ns0li5yaHEsQGLBmQQXlrjvPPA0OMa3/YGNqdv0h5BkoeZN+lXfA 0pkwmUhRjmbZWykw/ud+qo2GpbNlQlgEK21LfFKtmDGmCoXpjbJ/Iv1rcHug0GcZcL wEOxCHwsY/dPg== Date: Fri, 28 Jan 2022 13:45:40 +0100 From: Mauro Carvalho Chehab To: Yong Wu , Matthias Brugger Subject: Re: [PATCH v10 02/13] iommu/mediatek-v1: Free the existed fwspec if the master dev already has Message-ID: <20220128134540.00c6c380@coco.lan> In-Reply-To: <20220128134055.720bb43c@coco.lan> References: <20220117070510.17642-1-yong.wu@mediatek.com> <20220117070510.17642-3-yong.wu@mediatek.com> <20220128134055.720bb43c@coco.lan> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dafna Hirschfeld , Chun-Kuang Hu , David Airlie , Will Deacon , dri-devel@lists.freedesktop.org, yf.wang@mediatek.com, Hans Verkuil , anthony.huang@mediatek.com, youlin.pei@mediatek.com, Krzysztof Kozlowski , Evan Green , Eizan Miyamoto , Matthias Kaehlcke , mingyuan.ma@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Joerg Roedel , Frank Wunderlich , libo.kang@mediatek.com, yi.kuo@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Tiffany Lin , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , anan.sun@mediatek.com, srv_heupstream@mediatek.com, acourbot@chromium.org, linux-kernel@vger.kernel.org, Tomasz Figa , iommu@lists.linux-foundation.org, Robin Murphy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Em Fri, 28 Jan 2022 13:40:55 +0100 Mauro Carvalho Chehab escreveu: > Hi Matthias/Yong, > > Are you ok if this patch gets merged via the media tree together with the > remaining series, or do you prefer to apply it via SoC tree instead? Same questions for other patches touching files outside drivers/media on this pull request: https://patchwork.kernel.org/project/linux-mediatek/patch/7af52d61-47c7-581d-62ed-76a7f8315b16@xs4all.nl/ Like those: 0004-0013-iommu-mediatek-v1-Free-the-existed-fwspec-if-the-mas.patch 0005-0013-iommu-mediatek-Return-ENODEV-if-the-device-is-NULL.patch 0006-0013-iommu-mediatek-Add-probe_defer-for-smi-larb.patch 0007-0013-iommu-mediatek-Add-device_link-between-the-consumer-.patch Regards, Mauro > > Regards, > Mauro > > > Em Mon, 17 Jan 2022 15:04:59 +0800 > Yong Wu escreveu: > > > When the iommu master device enters of_iommu_xlate, the ops may be > > NULL(iommu dev is defered), then it will initialize the fwspec here: > > > > [] (dev_iommu_fwspec_set) from [] > > (iommu_fwspec_init+0xbc/0xd4) > > [] (iommu_fwspec_init) from [] > > (of_iommu_xlate+0x7c/0x12c) > > [] (of_iommu_xlate) from [] > > (of_iommu_configure+0x144/0x1e8) > > > > BUT the mtk_iommu_v1.c only supports arm32, the probing flow still is a bit > > weird. We always expect create the fwspec internally. otherwise it will > > enter here and return fail. > > > > static int mtk_iommu_create_mapping(struct device *dev, > > struct of_phandle_args *args) > > { > > ... > > if (!fwspec) { > > .... > > } else if (dev_iommu_fwspec_get(dev)->ops != &mtk_iommu_ops) { > > >>>>>>>>>>Enter here. return fail.<<<<<<<<<<<< > > return -EINVAL; > > } > > ... > > } > > > > Thus, Free the existed fwspec if the master device already has fwspec. > > > > This issue is reported at: > > https://lore.kernel.org/linux-mediatek/trinity-7d9ebdc9-4849-4d93-bfb5-429dcb4ee449-1626253158870@3c-app-gmx-bs01/ > > > > Reported-by: Frank Wunderlich > > Tested-by: Frank Wunderlich # BPI-R2/MT7623 > > Signed-off-by: Yong Wu > > Acked-by: Joerg Roedel > > Acked-by: AngeloGioacchino Del Regno > > --- > > drivers/iommu/mtk_iommu_v1.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c > > index be22fcf988ce..1467ba1e4417 100644 > > --- a/drivers/iommu/mtk_iommu_v1.c > > +++ b/drivers/iommu/mtk_iommu_v1.c > > @@ -425,6 +425,15 @@ static struct iommu_device *mtk_iommu_probe_device(struct device *dev) > > struct mtk_iommu_data *data; > > int err, idx = 0; > > > > + /* > > + * In the deferred case, free the existed fwspec. > > + * Always initialize the fwspec internally. > > + */ > > + if (fwspec) { > > + iommu_fwspec_free(dev); > > + fwspec = dev_iommu_fwspec_get(dev); > > + } > > + > > while (!of_parse_phandle_with_args(dev->of_node, "iommus", > > "#iommu-cells", > > idx, &iommu_spec)) { > > > > Thanks, > Mauro Thanks, Mauro