From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Siva Mullati <siva.mullati@intel.com>, dri-devel@lists.freedesktop.org
Subject: [PATCH v3 2/3] drm/i915: Fix header test for !CONFIG_X86
Date: Mon, 31 Jan 2022 08:59:25 -0800 [thread overview]
Message-ID: <20220131165926.3230642-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20220131165926.3230642-1-lucas.demarchi@intel.com>
Architectures others than x86 have a stub implementation calling
WARN_ON_ONCE(). The appropriate headers need to be included, otherwise
the header-test target will fail with:
HDRTEST drivers/gpu/drm/i915/i915_mm.h
In file included from <command-line>:
./drivers/gpu/drm/i915/i915_mm.h: In function ‘remap_io_mapping’:
./drivers/gpu/drm/i915/i915_mm.h:26:2: error: implicit declaration of function ‘WARN_ON_ONCE’ [-Werror=implicit-function-declaration]
26 | WARN_ON_ONCE(1);
| ^~~~~~~~~~~~
v2: Do not include <linux/printk.h> since call to pr_err() has been
removed
Fixes: 67c430bbaae1 ("drm/i915: Skip remap_io_mapping() for non-x86 platforms")
Cc: Siva Mullati <siva.mullati@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
v3: No changes from previous version, just submitting to the right
mailing list
drivers/gpu/drm/i915/i915_mm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_mm.h b/drivers/gpu/drm/i915/i915_mm.h
index 76f1d53bdf34..3ad22bbe80eb 100644
--- a/drivers/gpu/drm/i915/i915_mm.h
+++ b/drivers/gpu/drm/i915/i915_mm.h
@@ -6,6 +6,7 @@
#ifndef __I915_MM_H__
#define __I915_MM_H__
+#include <linux/bug.h>
#include <linux/types.h>
struct vm_area_struct;
--
2.35.0
next prev parent reply other threads:[~2022-01-31 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 16:59 [PATCH v3 0/3] drm/i915: Fix header test and log spam on !x86 Lucas De Marchi
2022-01-31 16:59 ` [PATCH v3 1/3] drm: Stop spamming log with drm_cache message Lucas De Marchi
2022-02-01 17:12 ` Souza, Jose
2022-02-01 17:41 ` Lucas De Marchi
2022-02-02 17:07 ` [Intel-gfx] " Rodrigo Vivi
2022-01-31 16:59 ` Lucas De Marchi [this message]
2022-02-01 8:48 ` [PATCH v3 2/3] drm/i915: Fix header test for !CONFIG_X86 Siva Mullati
2022-02-01 17:12 ` Souza, Jose
2022-01-31 16:59 ` [PATCH v3 3/3] drm/i915: Do not spam log with missing arch support Lucas De Marchi
2022-02-01 17:15 ` [Intel-gfx] " Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131165926.3230642-3-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=siva.mullati@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).