From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH v3 3/3] drm/i915: Do not spam log with missing arch support
Date: Mon, 31 Jan 2022 08:59:26 -0800 [thread overview]
Message-ID: <20220131165926.3230642-4-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20220131165926.3230642-1-lucas.demarchi@intel.com>
Following what was done in drm_cache.c, when the stub for
remap_io_mapping() was added in commit 67c430bbaae1 ("drm/i915: Skip
remap_io_mapping() for non-x86 platforms"), it included a log message
with pr_err(). However just the warning is already enough and switching
to WARN_ONCE() allows us to keep the log message while avoiding log
spam.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
v3: No changes from previous version, just submitting to the right
mailing list
drivers/gpu/drm/i915/i915_mm.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_mm.h b/drivers/gpu/drm/i915/i915_mm.h
index 3ad22bbe80eb..04c8974d822b 100644
--- a/drivers/gpu/drm/i915/i915_mm.h
+++ b/drivers/gpu/drm/i915/i915_mm.h
@@ -23,8 +23,7 @@ int remap_io_mapping(struct vm_area_struct *vma,
unsigned long addr, unsigned long pfn, unsigned long size,
struct io_mapping *iomap)
{
- pr_err("Architecture has no %s() and shouldn't be calling this function\n", __func__);
- WARN_ON_ONCE(1);
+ WARN_ONCE(1, "Architecture has no drm_cache.c support\n");
return 0;
}
#endif
--
2.35.0
next prev parent reply other threads:[~2022-01-31 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 16:59 [PATCH v3 0/3] drm/i915: Fix header test and log spam on !x86 Lucas De Marchi
2022-01-31 16:59 ` [PATCH v3 1/3] drm: Stop spamming log with drm_cache message Lucas De Marchi
2022-02-01 17:12 ` Souza, Jose
2022-02-01 17:41 ` Lucas De Marchi
2022-02-02 17:07 ` [Intel-gfx] " Rodrigo Vivi
2022-01-31 16:59 ` [PATCH v3 2/3] drm/i915: Fix header test for !CONFIG_X86 Lucas De Marchi
2022-02-01 8:48 ` Siva Mullati
2022-02-01 17:12 ` Souza, Jose
2022-01-31 16:59 ` Lucas De Marchi [this message]
2022-02-01 17:15 ` [Intel-gfx] [PATCH v3 3/3] drm/i915: Do not spam log with missing arch support Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131165926.3230642-4-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).