dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH v2 12/15] drm/i915/create: apply ALLOC_GPU_ONLY by default
Date: Thu, 10 Feb 2022 12:13:10 +0000	[thread overview]
Message-ID: <20220210121313.701004-13-matthew.auld@intel.com> (raw)
In-Reply-To: <20220210121313.701004-1-matthew.auld@intel.com>

Starting from DG2+, when dealing with LMEM, we assume that by default
all userspace allocations should be placed in the non-mappable portion
of LMEM.  Note that dumb buffers are not included here, since these are
not "GPU accelerated" and likely need CPU access.

In a later patch userspace will be able to provide a hint if CPU access
to the buffer is needed.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_create.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_create.c b/drivers/gpu/drm/i915/gem/i915_gem_create.c
index 9402d4bf4ffc..cc9ddb943f96 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_create.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_create.c
@@ -424,6 +424,15 @@ i915_gem_create_ext_ioctl(struct drm_device *dev, void *data,
 		ext_data.n_placements = 1;
 	}
 
+	/*
+	 * TODO: add a userspace hint to force CPU_ACCESS for the object, which
+	 * can override this.
+	 */
+	if (!IS_DG1(i915) && (ext_data.n_placements > 1 ||
+			      ext_data.placements[0]->type !=
+			      INTEL_MEMORY_SYSTEM))
+		ext_data.flags |= I915_BO_ALLOC_GPU_ONLY;
+
 	obj = __i915_gem_object_create_user_ext(i915, args->size,
 						ext_data.placements,
 						ext_data.n_placements,
-- 
2.34.1


  parent reply	other threads:[~2022-02-10 12:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 12:12 [PATCH v2 00/15] Initial support for small BAR recovery Matthew Auld
2022-02-10 12:12 ` [PATCH v2 01/15] drm/i915: add io_size plumbing Matthew Auld
2022-02-10 12:13 ` [PATCH v2 02/15] drm/i915/ttm: require mappable by default Matthew Auld
2022-02-11  9:20   ` Thomas Hellström
2022-02-10 12:13 ` [PATCH v2 03/15] drm/i915: add I915_BO_ALLOC_GPU_ONLY Matthew Auld
2022-02-11  9:23   ` Thomas Hellström
2022-02-10 12:13 ` [PATCH v2 04/15] drm/i915/buddy: track available visible size Matthew Auld
2022-02-11  9:25   ` Thomas Hellström
2022-02-10 12:13 ` [PATCH v2 05/15] drm/i915/buddy: adjust res->start Matthew Auld
2022-02-10 12:13 ` [PATCH v2 06/15] drm/i915/buddy: tweak 2big check Matthew Auld
2022-02-10 12:13 ` [PATCH v2 07/15] drm/i915/selftests: mock test io_size Matthew Auld
2022-02-10 12:13 ` [PATCH v2 08/15] drm/i915/ttm: make eviction mappable aware Matthew Auld
2022-02-10 12:13 ` [PATCH v2 09/15] drm/i915/ttm: mappable migration on fault Matthew Auld
2022-02-10 12:13 ` [PATCH v2 10/15] drm/i915/selftests: exercise mmap migration Matthew Auld
2022-02-11  9:36   ` Thomas Hellström
2022-02-10 12:13 ` [PATCH v2 11/15] drm/i915/selftests: handle allocation failures Matthew Auld
2022-02-11  9:37   ` Thomas Hellström
2022-02-10 12:13 ` Matthew Auld [this message]
2022-02-11  9:49   ` [PATCH v2 12/15] drm/i915/create: apply ALLOC_GPU_ONLY by default Thomas Hellström
2022-02-11  9:52     ` [Intel-gfx] " Matthew Auld
2022-02-11  9:55       ` Thomas Hellström
2022-02-11 10:00         ` Matthew Auld
2022-02-11 10:14           ` Thomas Hellström
2022-02-10 12:13 ` [PATCH v2 13/15] drm/i915/uapi: add NEEDS_CPU_ACCESS hint Matthew Auld
2022-02-11  9:59   ` Thomas Hellström
2022-02-10 12:13 ` [PATCH v2 14/15] drm/i915/uapi: forbid ALLOC_GPU_ONLY for error capture Matthew Auld
2022-02-11 10:06   ` Thomas Hellström
2022-02-10 12:13 ` [PATCH v2 15/15] drm/i915/lmem: don't treat small BAR as an error Matthew Auld
2022-02-11 10:08   ` Thomas Hellström
2022-02-10 14:40 ` [Intel-gfx] [PATCH v2 00/15] Initial support for small BAR recovery Das, Nirmoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210121313.701004-13-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox