From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B145CC433FE for ; Thu, 17 Feb 2022 13:58:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D2C310E296; Thu, 17 Feb 2022 13:58:29 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B2F110E296 for ; Thu, 17 Feb 2022 13:58:27 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKhIf-0006oN-DP; Thu, 17 Feb 2022 14:58:25 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nKhId-0001Dm-1L; Thu, 17 Feb 2022 14:58:23 +0100 Date: Thu, 17 Feb 2022 14:58:23 +0100 From: Sascha Hauer To: Andy Yan Subject: Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver Message-ID: <20220217135823.GR18637@pengutronix.de> References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217082954.2967889-22-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:41:20 up 68 days, 22:26, 86 users, load average: 0.14, 0.15, 0.15 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Andy, Please trim the context in your answers to the relevant parts, it makes it easier to find the things you said. On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > Hi Sascha: > > > + > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->encoder_mask) { > > + struct rockchip_encoder *rkencoder = to_rockchip_encoder(encoder); > > + struct device_node *node, *parent; > > + > > + parent = of_get_parent(rkencoder->port); > > + > > + for_each_endpoint_of_node(parent, node) { > > Is there any hurt directly use our downstream vendor kernel method here: use > vcstate->output_if set by encoder driver to get which interface we should > enable here? There is no vcstate->output_if in mainline currently. Ok, we could add that. The other thing is that there are multiple HDMI interfaces and the id of the HDMI encoder is encoded into output_if. Downstream kernel adds OF aliases to the HDMI ports. I didn't want to go that route because it doesn't seem to be very elegant to me. > > You method is ok with device tree,  but it tied up this driver to device > tree, we are now tring to extend vop2 driver work with ACPI, so we hope this > driver can be much more flexible. The current rockchip drm driver seems to be pretty much tied to device tree. There are probably many other places that need parallel paths for ACPI support, I think we can delay this particular part until we see the whole picture. In the end we can still retrieve the output_if information differently with ACPI while still retrieving the information from the device tree the way we are doing currently. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |