From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA409C433F5 for ; Mon, 21 Feb 2022 10:00:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B55310EAAF; Mon, 21 Feb 2022 10:00:03 +0000 (UTC) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4366B10E463 for ; Mon, 21 Feb 2022 09:59:43 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 9C6CB58025D; Mon, 21 Feb 2022 04:59:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 21 Feb 2022 04:59:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=zI+A8kuccAxz9CqqXVtqcAMYRs+IUY h/SEHu9k6niCs=; b=BLSJEY3V0mfH9jEO9ZWqPJLYg6cMLW5eAYY1r/2v/vv31I BG2KK8xkNJqDtbfPZx1nCWit6U8xdpwwt9iJeIww+pfJ+reVf56TQvx+PlhXyWzO G0D6mrjRS+yqqgtP6llGbrhsPdqF2wYjO2BOsC+J7sKXJGnycx7RTx2ddaZys9w+ VQw5RcCj3G28qdQoIXIPbhyhN3IC//ABwgu1LNxB3u7AlxNrfxskw5WPkyFyfked KvoTYL9kwxSZaNr4UCqvHi6B/rD8y7zcPxSvvjTK5gF8AYzfcBv8MaZn863dEdF0 r7huKZqyRxHMjtsoBaR8obcS/0e5O46Ucy4FOICw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zI+A8k uccAxz9CqqXVtqcAMYRs+IUYh/SEHu9k6niCs=; b=FQIdzKMMtPnhT6rNGbdU0T h47ofkrjw0FYZjHHuIEQexxKM2IhGxzjNb05XanTGlnbVV9ZsGRHDCya5FSpLRdP EhcwzfPz/m0FuQSZZnCS6MJBp/Idnf3/sLvKNhJnzPPzSdxGAYckUfJ1Lo+dXUpG hN0xKzaI/+os/6NhFLsN0P8SMJThdXUTl+nbDr9ec4OjDHpXi2qzZ//AwOsAraG8 HcZAi3pGVY9l2Jw7SgOOt1gDZWaG8rosQzYwg68wDMtOVgi6IYkzqW7iHBvMBC7E eq083ylxMZf5boCYH1ovNhy8ivJ+mzvob1UfhwNPg4O03QJLU/0ihzMguukblbRg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeigddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Feb 2022 04:59:41 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Subject: [PATCH v2 09/22] drm/komeda: plane: Remove redundant zpos initialisation Date: Mon, 21 Feb 2022 10:59:05 +0100 Message-Id: <20220221095918.18763-10-maxime@cerno.tech> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech> References: <20220221095918.18763-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , Liviu Dudau , dri-devel@lists.freedesktop.org, "James \(Qian\) Wang" , Maxime Ripard , Thomas Zimmermann , Mihail Atanassov , Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The komeda KMS driver will call drm_plane_create_zpos_property() with an init value of the plane index. Since the initial value wasn't carried over in the state, the driver had to set it again in komeda_plane_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: Brian Starkey Cc: "James (Qian) Wang" Cc: Liviu Dudau Cc: Mihail Atanassov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c index 1778f6e1ea56..383bb2039bd4 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c @@ -135,7 +135,6 @@ static void komeda_plane_destroy(struct drm_plane *plane) static void komeda_plane_reset(struct drm_plane *plane) { struct komeda_plane_state *state; - struct komeda_plane *kplane = to_kplane(plane); if (plane->state) __drm_atomic_helper_plane_destroy_state(plane->state); @@ -146,7 +145,6 @@ static void komeda_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (state) { __drm_atomic_helper_plane_reset(plane, &state->base); - state->base.zpos = kplane->layer->base.id; state->base.color_encoding = DRM_COLOR_YCBCR_BT601; state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE; } -- 2.35.1