From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A941C433F5 for ; Mon, 21 Feb 2022 09:59:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DA8910E307; Mon, 21 Feb 2022 09:59:30 +0000 (UTC) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by gabe.freedesktop.org (Postfix) with ESMTPS id 952D110E2FE for ; Mon, 21 Feb 2022 09:59:25 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 11FA0580259; Mon, 21 Feb 2022 04:59:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 21 Feb 2022 04:59:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=NYWW80GsyUCeEqj7HkaGsRQxvtLYVY 4L2V9iEh7oljA=; b=BodkgIua9GOdsnUxgmeG89y+tLA9yUuItiRuYDmWbEI0D6 37uhZB/6fPD43MZK+YzbFU5SlLhyjz2jkPDtZPJ++vuoOGU1GqyueWTlqaB1WkPQ mkbxTPgGqWFDsEpAN5bsKhOhzpigT/6KfRzznVWhSxbI8in9xT03d2ePihIlOfXw XIAhaI36SO6/LMyJWEWCbNclrbQjLYEHZRerS+rgkgT04taOFCk06lkvWWwEgkmQ RQz+fxt08LROsOMh8UFUO3UvJAiEYGX6AiUg/1eNWV6uVpS/++ZqlS3Ie++Vd6P2 iQGQjhDOkRoOpHRGkpckkwgfNLSB0Bxmk9ZKIufw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=NYWW80 GsyUCeEqj7HkaGsRQxvtLYVY4L2V9iEh7oljA=; b=fFaF+pNif3Vvmwo3Sk8qCN NY/nld8llzNvdkV8UAj5Sm2sNfEVhYvFxcUL6AN1fHtZ+jDZyDw5ke2phL2Qanft Ie2RtvC0HYeGfsL7sc2iGjqJfw8lbTUQHs3v2afo18/DylT6bMYQWEjwpvIzROu2 aWLkRnVWEIyS3cWwMWp7HeeXfLGrNIgJJKNYl8B67U+q2ISOe71zjdZNBeWiSC0j gahLwY/4t/wCNR0oH72fMJgTpJKkXLHMBU4Fv8gaMoPWNTwCCxmu1KODpEFwJftG ZhxVZeLbr9eAptE4L400MszIx4uJEb+LEy55+KKt0XoPZFToXW4rmXVnXmlTwOLg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeigddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Feb 2022 04:59:22 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Subject: [PATCH v2 01/22] drm/komeda: plane: switch to plane reset helper Date: Mon, 21 Feb 2022 10:58:57 +0100 Message-Id: <20220221095918.18763-2-maxime@cerno.tech> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech> References: <20220221095918.18763-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , Liviu Dudau , dri-devel@lists.freedesktop.org, "James \(Qian\) Wang" , Maxime Ripard , Thomas Zimmermann , Mihail Atanassov , Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" komeda_plane_reset() does the state initialisation by copying a lot of the code found in the __drm_atomic_helper_plane_reset(). Let's switch to that helper and reduce the boilerplate. Cc: Brian Starkey Cc: "James (Qian) Wang" Cc: Liviu Dudau Cc: Mihail Atanassov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c index d63d83800a8a..1778f6e1ea56 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c @@ -145,14 +145,10 @@ static void komeda_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (state) { - state->base.rotation = DRM_MODE_ROTATE_0; - state->base.pixel_blend_mode = DRM_MODE_BLEND_PREMULTI; - state->base.alpha = DRM_BLEND_ALPHA_OPAQUE; + __drm_atomic_helper_plane_reset(plane, &state->base); state->base.zpos = kplane->layer->base.id; state->base.color_encoding = DRM_COLOR_YCBCR_BT601; state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE; - plane->state = &state->base; - plane->state->plane = plane; } } -- 2.35.1