From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDB62C433F5 for ; Mon, 21 Feb 2022 10:00:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 093A110EDF6; Mon, 21 Feb 2022 10:00:34 +0000 (UTC) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by gabe.freedesktop.org (Postfix) with ESMTPS id 302C310EADC for ; Mon, 21 Feb 2022 10:00:08 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 8C00C58025B; Mon, 21 Feb 2022 05:00:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 21 Feb 2022 05:00:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=FTFKvgV2OHoBu/E5AiuTWzVmTJjhQz qREeJDAWc3oMs=; b=oPUgrHb3dTqCihPkvqhw+ybvc/AQCnfgVryXYVJmIc52U7 U3x2eiLqt8Nz8t2GztR+furUdjgVotO0JwsqijNkP3lUsa23E7URQguJqx31id3x XvlDNQ9OcZzZVaQbjRs3OS7ATdaBp/QYShJ9vt/3wm5sy3BdA0vGz43EmidyPZEv Irdz60bJVezDEbaaz3gQ1Li1fulITq0R2PnOM7i6SKl0HbGk0gBqURSmgbrkcfX0 EDD2mKeOWUmgH/nY9mpivD4e/VGbTvj89Eh/FGOGGnit97TlyIYTeYPjsO/rTTS3 rU4G3PXqpH8qKAYyCmYbh4sP3UGEw26RQara77Jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FTFKvg V2OHoBu/E5AiuTWzVmTJjhQzqREeJDAWc3oMs=; b=G+oj6x0/wafshFUsu/rLDs 7nIMYqZd8e1ePc4WtmS9qPq2bnt5+njJPgOH1AAhcJZ9xJ9WqKXU6fLFNnwxGl0f D8qOOIkn5VmScHoBk5rr+heZ6BtVK8AQyl0JPJ9bmhZmOK82zAqMe8CX2qsPOaHn X3JH5baTho/yJW6g7vjOtGTvs2Jh708ROAug7Nx36hcA0vi8WoBPSzu9+/IOW/Ro bKMn0tdCCy0tycz5Y8wkWGzRozezkQ90XZSZeyKt+aMfGr7bTUrmf4trIAJ/+DH8 oG7iMs9kQ22PPTxO0oiLyuuqE1npCzvhVx1K0yOhF5A2OtsdjuY9qtwbbmqueuLA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeigddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpeefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Feb 2022 05:00:06 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Subject: [PATCH v2 19/22] drm/komeda: plane: Remove redundant color encoding and range initialisation Date: Mon, 21 Feb 2022 10:59:15 +0100 Message-Id: <20220221095918.18763-20-maxime@cerno.tech> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech> References: <20220221095918.18763-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , Liviu Dudau , dri-devel@lists.freedesktop.org, "James \(Qian\) Wang" , Maxime Ripard , Thomas Zimmermann , Mihail Atanassov , Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The komeda KMS driver will call drm_plane_create_color_properties() with a default encoding and range values of BT601 and Limited Range, respectively. Since the initial value wasn't carried over in the state, the driver had to set it again in komeda_plane_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: Brian Starkey Cc: "James (Qian) Wang" Cc: Liviu Dudau Cc: Mihail Atanassov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c index 383bb2039bd4..541949f2d44a 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c @@ -143,11 +143,8 @@ static void komeda_plane_reset(struct drm_plane *plane) plane->state = NULL; state = kzalloc(sizeof(*state), GFP_KERNEL); - if (state) { + if (state) __drm_atomic_helper_plane_reset(plane, &state->base); - state->base.color_encoding = DRM_COLOR_YCBCR_BT601; - state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE; - } } static struct drm_plane_state * -- 2.35.1